Add NodePool Provisioning Status Condition Constants #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a single condition type for tracking the NodePool provisioning status, with various condition reasons to represent different states in the provisioning process. This simplifies the condition handling by focusing on one type with multiple reasons for clarity and consistency. Signed-off-by: Tao Liu <[email protected]>
|
/lgtm |
Missxiaoguo
approved these changes
Aug 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Missxiaoguo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
donpenney
reviewed
Aug 22, 2024
| Unprovisioned ConditionReason = "Unprovisioned" | ||
| Failed ConditionReason = "Failed" | ||
| NotInitialized ConditionReason = "NotInitialized" | ||
| ) |
There was a problem hiding this comment.
These would be more convenient if setup similar to the condition types and reasons as in:
https://github.com/openshift-kni/oran-o2ims/blob/main/internal/controllers/utils/conditions.go#L8-L48
Something like:
// ConditionReason is a string representing the condition's reason
type ConditionReason string
// The following constants define the different reasons that conditions will be set for the resource
var ResourceConditionReasons = struct {
Completed ConditionReason
InProgress ConditionReason
Failed ConditionReason
}{
Completed: "Completed",
InProgress: "InProgress",
Failed: "Failed",
}
Rather than a random collection of constants, they're grouped and referenced like:
hwmgmtv1alpha1.ResourceConditionReasons.InProgress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single condition type for tracking the NodePool provisioning status, with various condition reasons to represent different states in the provisioning process. This simplifies the condition handling by focusing on one type with multiple reasons for clarity and consistency.