-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNF-13958: Enable TLS verification for in-cluster deployments #177
CNF-13958: Enable TLS verification for in-cluster deployments #177
Conversation
@alegacy: This pull request references CNF-13958 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
internal/controllers/utils/utils.go
Outdated
} | ||
|
||
if data, err := os.ReadFile(defaultServiceCAFile); err != nil { | ||
return fmt.Errorf("failed to read service CA rile '%s': %w", defaultServiceCAFile, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: rile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, fixed.
This configures the TLS clients using the service account root CA bundles so that we can properly verify the identity of backend servers. Signed-off-by: Allain Legacy <[email protected]>
016b6ca
to
1baa135
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irinamihai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ift-kni#177) This configures the TLS clients using the service account root CA bundles so that we can properly verify the identity of backend servers. Signed-off-by: Allain Legacy <[email protected]>
This configures the TLS clients using the service account root CA bundles so that we can properly verify the identity of backend servers.