Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Add diffutils package to buildroot image #174

Merged

Conversation

donpenney
Copy link
Collaborator

Certain golangci-lint linters require the diff util, which is not installed by default in the ubi-minimal image, which is used for the buildroot image in the CI. This must be a standalone commit as the CI gets the Containerfile.tools file from the branch HEAD, rather than the PR being tested.

Certain golangci-lint linters require the diff util, which is not
installed by default in the ubi-minimal image, which is used for the
buildroot image in the CI. This must be a standalone commit as the CI
gets the Containerfile.tools file from the branch HEAD, rather than the
PR being tested.

Signed-off-by: Don Penney <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

@donpenney: This pull request explicitly references no jira issue.

In response to this:

Certain golangci-lint linters require the diff util, which is not installed by default in the ubi-minimal image, which is used for the buildroot image in the CI. This must be a standalone commit as the CI gets the Containerfile.tools file from the branch HEAD, rather than the PR being tested.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alegacy
Copy link
Contributor

alegacy commented Aug 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@donpenney
Copy link
Collaborator Author

/approve

Copy link

openshift-ci bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 96c68bf into openshift-kni:main Aug 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants