Addressing comments from Angie

openshift-kni · Sep 27, 2024 · 2f815fe · 2f815fe
1 parent fb65a38
commit 2f815fe
Show file tree

Hide file tree

Showing 3 changed files with 90 additions and 67 deletions.
diff --git a/internal/controllers/clusterrequest_controller.go b/internal/controllers/clusterrequest_controller.go
@@ -321,7 +321,7 @@ func (t *clusterRequestReconcilerTask) handleValidation(ctx context.Context) err
 		)
 		utils.SetStatusCondition(&t.object.Status.Conditions,
 			utils.CRconditionTypes.Validated,
-			utils.Failed,
+			utils.CRconditionReasons.Failed,
 			metav1.ConditionFalse,
 			"Failed to validate the ClusterRequest: "+err.Error(),
 		)
@@ -333,7 +333,7 @@ func (t *clusterRequestReconcilerTask) handleValidation(ctx context.Context) err
 		)
 		utils.SetStatusCondition(&t.object.Status.Conditions,
 			utils.CRconditionTypes.Validated,
-			utils.Completed,
+			utils.CRconditionReasons.Completed,
 			metav1.ConditionTrue,
 			"The cluster request validation succeeded",
 		)
@@ -472,7 +472,7 @@ func (t *clusterRequestReconcilerTask) handleRenderClusterInstance(ctx context.C
 		)
 		utils.SetStatusCondition(&t.object.Status.Conditions,
 			utils.CRconditionTypes.ClusterInstanceRendered,
-			utils.Failed,
+			utils.CRconditionReasons.Failed,
 			metav1.ConditionFalse,
 			"Failed to render and validate ClusterInstance: "+err.Error(),
 		)
@@ -485,7 +485,7 @@ func (t *clusterRequestReconcilerTask) handleRenderClusterInstance(ctx context.C
 
 		utils.SetStatusCondition(&t.object.Status.Conditions,
 			utils.CRconditionTypes.ClusterInstanceRendered,
-			utils.Completed,
+			utils.CRconditionReasons.Completed,
 			metav1.ConditionTrue,
 			"ClusterInstance rendered and passed dry-run validation",
 		)
@@ -540,7 +540,7 @@ func (t *clusterRequestReconcilerTask) renderClusterInstanceTemplate(
 		// with the exception of scaling up/down when Cluster provisioning is completed.
 		crProvisionedCond := meta.FindStatusCondition(t.object.Status.Conditions,
 			string(utils.CRconditionTypes.ClusterProvisioned))
-		if crProvisionedCond != nil && crProvisionedCond.Reason != string(utils.Unknown) {
+		if crProvisionedCond != nil && crProvisionedCond.Reason != string(utils.CRconditionReasons.Unknown) {
 			existingClusterInstance := &unstructured.Unstructured{}
 			existingClusterInstance.SetGroupVersionKind(
 				renderedClusterInstanceUnstructure.GroupVersionKind())
@@ -564,7 +564,7 @@ func (t *clusterRequestReconcilerTask) renderClusterInstanceTemplate(
 					disallowedChanges = append(disallowedChanges, updatedFields...)
 				}
 				if len(scalingNodes) != 0 &&
-					crProvisionedCond.Reason != string(utils.Completed) {
+					crProvisionedCond.Reason != string(utils.CRconditionReasons.Completed) {
 					// In-progress || Failed
 					disallowedChanges = append(disallowedChanges, scalingNodes...)
 				}
@@ -606,7 +606,7 @@ func (t *clusterRequestReconcilerTask) handleClusterResources(ctx context.Contex
 
 		utils.SetStatusCondition(&t.object.Status.Conditions,
 			utils.CRconditionTypes.ClusterResourcesCreated,
-			utils.Failed,
+			utils.CRconditionReasons.Failed,
 			metav1.ConditionFalse,
 			"Failed to apply the required cluster resource: "+err.Error(),
 		)
@@ -619,7 +619,7 @@ func (t *clusterRequestReconcilerTask) handleClusterResources(ctx context.Contex
 
 		utils.SetStatusCondition(&t.object.Status.Conditions,
 			utils.CRconditionTypes.ClusterResourcesCreated,
-			utils.Completed,
+			utils.CRconditionReasons.Completed,
 			metav1.ConditionTrue,
 			"Cluster resources applied",
 		)
@@ -644,7 +644,7 @@ func (t *clusterRequestReconcilerTask) renderHardwareTemplate(ctx context.Contex
 
 		utils.SetStatusCondition(&t.object.Status.Conditions,
 			utils.CRconditionTypes.HardwareTemplateRendered,
-			utils.Failed,
+			utils.CRconditionReasons.Failed,
 			metav1.ConditionFalse,
 			"Failed to render the Hardware template: "+err.Error(),
 		)
@@ -657,7 +657,7 @@ func (t *clusterRequestReconcilerTask) renderHardwareTemplate(ctx context.Contex
 
 		utils.SetStatusCondition(&t.object.Status.Conditions,
 			utils.CRconditionTypes.HardwareTemplateRendered,
-			utils.Completed,
+			utils.CRconditionReasons.Completed,
 			metav1.ConditionTrue,
 			"Rendered Hardware template successfully",
 		)
@@ -871,7 +871,7 @@ func (t *clusterRequestReconcilerTask) handleClusterInstallation(ctx context.Con
 		}
 		utils.SetStatusCondition(&t.object.Status.Conditions,
 			utils.CRconditionTypes.ClusterInstanceProcessed,
-			utils.NotApplied,
+			utils.CRconditionReasons.NotApplied,
 			metav1.ConditionFalse,
 			fmt.Sprintf(
 				"Failed to apply the rendered ClusterInstance (%s): %s",
@@ -1027,7 +1027,7 @@ func (t *clusterRequestReconcilerTask) updateClusterInstanceProcessedStatus(ci *
 	if len(ci.Status.Conditions) == 0 {
 		utils.SetStatusCondition(&t.object.Status.Conditions,
 			utils.CRconditionTypes.ClusterInstanceProcessed,
-			utils.Unknown,
+			utils.CRconditionReasons.Unknown,
 			metav1.ConditionUnknown,
 			fmt.Sprintf("Waiting for ClusterInstance (%s) to be processed", ci.Name),
 		)
@@ -1050,7 +1050,7 @@ func (t *clusterRequestReconcilerTask) updateClusterInstanceProcessedStatus(ci *
 
 	utils.SetStatusCondition(&t.object.Status.Conditions,
 		utils.CRconditionTypes.ClusterInstanceProcessed,
-		utils.Completed,
+		utils.CRconditionReasons.Completed,
 		metav1.ConditionTrue,
 		fmt.Sprintf("Applied and processed ClusterInstance (%s) successfully", ci.Name),
 	)
@@ -1071,7 +1071,7 @@ func (t *clusterRequestReconcilerTask) updateClusterProvisionStatus(ci *siteconf
 		if crClusterInstanceProcessedCond != nil && crClusterInstanceProcessedCond.Status == metav1.ConditionTrue {
 			utils.SetStatusCondition(&t.object.Status.Conditions,
 				utils.CRconditionTypes.ClusterProvisioned,
-				utils.Unknown,
+				utils.CRconditionReasons.Unknown,
 				metav1.ConditionUnknown,
 				"Waiting for cluster provisioning to start",
 			)
@@ -1858,7 +1858,7 @@ func (t *clusterRequestReconcilerTask) updateHardwareProvisioningStatus(
 		} else {
 			utils.SetStatusCondition(&t.object.Status.Conditions,
 				utils.CRconditionTypes.HardwareProvisioned,
-				utils.Unknown,
+				utils.CRconditionReasons.Unknown,
 				metav1.ConditionUnknown,
 				"Unknown state of hardware provisioning",
 			)