Add unit tests for NodePool related functions #334
tliu2021check-pull-request.yaml
on: pull_request
Build image
1m 23s
Unit tests
1m 49s
Check generated code
51s
Lint
1m 30s
Annotations
3 errors
|
Lint:
internal/controllers/clusterrequest_controller_test.go#L1836
paramTypeCombine: func(name, bmcAddress, bmcSecret, mac, groupName string, namespace string, npName string) *hwv1alpha1.Node could be replaced with func(name, bmcAddress, bmcSecret, mac, groupName, namespace, npName string) *hwv1alpha1.Node (gocritic)
|
|
Lint:
internal/controllers/clusterrequest_controller_test.go#L1887
paramTypeCombine: func(c client.Client, ctx context.Context, nodes []*hwv1alpha1.Node, mhost string, whost string) could be replaced with func(c client.Client, ctx context.Context, nodes []*hwv1alpha1.Node, mhost, whost string) (gocritic)
|
|
Lint
issues found
|