DNM: Testing #324
donpenneycheck-pull-request.yaml
on: pull_request
Build image
1m 16s
Unit tests
2m 15s
Check generated code
17s
Lint
51s
Annotations
10 errors
|
Lint:
internal/controllers/orano2ims_controller.go#L114
cyclomatic complexity 32 of func `(*reconcilerTask).run` is high (> 30) (gocyclo)
|
|
Lint:
internal/controllers/suite_test.go#L41
getFakeClientFromObjects - result 1 (error) is always nil (unparam)
|
|
Lint:
internal/controllers/orano2ims_controller.go#L392
error returned from external package is unwrapped: sig: func github.com/openshift-kni/oran-o2ims/internal/controllers/utils.CreateK8sCR(ctx context.Context, c sigs.k8s.io/controller-runtime/pkg/client.Client, newObject sigs.k8s.io/controller-runtime/pkg/client.Object, ownerObject sigs.k8s.io/controller-runtime/pkg/client.Object, operation string) (err error) (wrapcheck)
|
|
Lint:
internal/controllers/orano2ims_controller.go#L419
error returned from external package is unwrapped: sig: func github.com/openshift-kni/oran-o2ims/internal/controllers/utils.CreateK8sCR(ctx context.Context, c sigs.k8s.io/controller-runtime/pkg/client.Client, newObject sigs.k8s.io/controller-runtime/pkg/client.Object, ownerObject sigs.k8s.io/controller-runtime/pkg/client.Object, operation string) (err error) (wrapcheck)
|
|
Lint:
internal/controllers/orano2ims_controller.go#L447
error returned from external package is unwrapped: sig: func github.com/openshift-kni/oran-o2ims/internal/controllers/utils.GetServerArgs(ctx context.Context, c sigs.k8s.io/controller-runtime/pkg/client.Client, orano2ims *github.com/openshift-kni/oran-o2ims/api/v1alpha1.ORANO2IMS, serverName string) (result []string, err error) (wrapcheck)
|
|
Lint:
internal/controllers/orano2ims_controller.go#L505
error returned from external package is unwrapped: sig: func github.com/openshift-kni/oran-o2ims/internal/controllers/utils.CreateK8sCR(ctx context.Context, c sigs.k8s.io/controller-runtime/pkg/client.Client, newObject sigs.k8s.io/controller-runtime/pkg/client.Object, ownerObject sigs.k8s.io/controller-runtime/pkg/client.Object, operation string) (err error) (wrapcheck)
|
|
Lint:
internal/controllers/orano2ims_controller.go#L748
error returned from interface method should be wrapped: sig: func (sigs.k8s.io/controller-runtime/pkg/client.SubResourceWriter).Update(ctx context.Context, obj sigs.k8s.io/controller-runtime/pkg/client.Object, opts ...sigs.k8s.io/controller-runtime/pkg/client.SubResourceUpdateOption) error (wrapcheck)
|
|
Lint:
internal/controllers/orano2ims_controller.go#L752
error returned from external package is unwrapped: sig: func k8s.io/client-go/util/retry.RetryOnConflict(backoff k8s.io/apimachinery/pkg/util/wait.Backoff, fn func() error) error (wrapcheck)
|
|
Lint:
internal/controllers/orano2ims_controller.go#L820
error returned from external package is unwrapped: sig: func (*sigs.k8s.io/controller-runtime/pkg/builder.Builder).Complete(r sigs.k8s.io/controller-runtime/pkg/reconcile.Reconciler) error (wrapcheck)
|
|
Lint:
internal/network/listener_test.go#L159
octalLiteral: use new octal literal style, 0o600 (gocritic)
|