Skip to content

Merge pull request #19 from mcornea/lint #1

Merge pull request #19 from mcornea/lint

Merge pull request #19 from mcornea/lint #1

Triggered via push September 27, 2023 11:10
Status Failure
Total duration 4m 21s
Artifacts

makefile.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

10 errors
build: tests/gitopsztp/internal/gitopsztphelper/gitopsztphelper.go#L394
cognitive complexity 34 of func `WaitUntilArgocdChangeIsCompleted` is high (> 30) (gocognit)
build: tests/gitopsztp/internal/gitopsztpparams/talmparameters.go#L8
exported: exported const TalmUpdatedConditionsVersion should have comment (or a comment on this block) or be unexported (revive)
build: tests/gitopsztp/internal/gitopsztpparams/talmparameters.go#L21
exported: comment on exported const PolicyNameCommonName should be of the form "PolicyNameCommonName ..." (revive)
build: tests/gitopsztp/internal/gitopsztpparams/gitopsztpparams.go#L5
exported: exported type ArgocdGitDetails should have comment or be unexported (revive)
build: tests/gitopsztp/internal/gitopsztpparams/gitopsztpparams.go#L12
exported: comment on exported const ZtpTestNamespace should be of the form "ZtpTestNamespace ..." (revive)
build: tests/gitopsztp/internal/gitopsztpparams/gitopsztpparams.go#L15
exported: exported const HubKubeEnvKey should have comment (or a comment on this block) or be unexported (revive)
build: tests/gitopsztp/internal/gitopsztphelper/gitopsztphelper.go#L33
var-naming: don't use underscores in Go names; var cnf_test_image should be cnfTestImage (revive)
build: tests/gitopsztp/internal/gitopsztphelper/gitopsztphelper.go#L34
exported: exported var HubAPIClient should have comment or be unexported (revive)
build: tests/gitopsztp/internal/gitopsztphelper/gitopsztphelper.go#L53
exported: comment on exported function SetGitDetailsInArcgocd should be of the form "SetGitDetailsInArcgocd ..." (revive)
build: tests/gitopsztp/internal/gitopsztphelper/gitopsztphelper.go#L84
exported: exported function GetOperatorVersionFromCSV should have comment or be unexported (revive)