Specify static entries namespace #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liornoy
force-pushed
the
specify-static-entries-namespace
branch
from
c51aaae
to
705e741
Compare
| @@ -263,7 +285,7 @@ var generalStaticEntriesMaster = []types.ComDetails{ | |||
| Port: "6080", | |||
| NodeRole: "master", | |||
| Service: "", | |||
| Namespace: "openshift-kube-apiserver-readyz", | |||
| Namespace: "openshift-kube-apiserver-ready", | |||
| Pod: "kube-apiserver", | |||
| Container: "kube-apiserver-insecure-readyz", | |||
There was a problem hiding this comment.
fixed. the namespace is entirely without the -readyz, just openshift-kube-apiserver
liornoy
force-pushed
the
specify-static-entries-namespace
branch
4 times, most recently
from
4591d2b
to
7af0941
Compare
liornoy
force-pushed
the
specify-static-entries-namespace
branch
2 times, most recently
from
acc67bb
to
19fc381
Compare
This commit updates the static-custom-entries.go. fill the namespaces of some static custom entries, and renames the variable name of cloudStaticEntries to be cloud generic and not specific for AWS. Signed-off-by: Lior Noy <[email protected]>
liornoy
force-pushed
the
specify-static-entries-namespace
branch
from
19fc381
to
8e1c369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify static entries namespaces
This commit updates the static-custom-entries.go. fill the namespaces of some static custom entries, and renames the variable name of cloudStaticEntries to be cloud generic and not specific for AWS.