Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Implement SQL validation based on grammar element #3044

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a87893a from #3039.

* Implement SQL validation based on grammar element

Signed-off-by: Tomoyuki Morita <[email protected]>

* Add function types

Signed-off-by: Tomoyuki Morita <[email protected]>

* fix style

Signed-off-by: Tomoyuki Morita <[email protected]>

* Add security lake

Signed-off-by: Tomoyuki Morita <[email protected]>

* Add File support

Signed-off-by: Tomoyuki Morita <[email protected]>

* Integrate into SparkQueryDispatcher

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix style

Signed-off-by: Tomoyuki Morita <[email protected]>

* Add tests

Signed-off-by: Tomoyuki Morita <[email protected]>

* Integration

Signed-off-by: Tomoyuki Morita <[email protected]>

* Add comments

Signed-off-by: Tomoyuki Morita <[email protected]>

* Address comments

Signed-off-by: Tomoyuki Morita <[email protected]>

* Allow join types for now

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix style

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix coverage check

Signed-off-by: Tomoyuki Morita <[email protected]>

---------

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit a87893a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 99.69880% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.49%. Comparing base (a20f655) to head (b9d7041).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...sql/spark/validator/SQLQueryValidationVisitor.java 99.46% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #3044      +/-   ##
============================================
+ Coverage     94.38%   94.49%   +0.10%     
- Complexity     5313     5422     +109     
============================================
  Files           521      530       +9     
  Lines         15144    15447     +303     
  Branches       1005     1010       +5     
============================================
+ Hits          14294    14596     +302     
  Misses          804      804              
- Partials         46       47       +1     
Flag Coverage Δ
sql-engine 94.49% <99.69%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ykmr1224 ykmr1224 merged commit 5ed2a28 into 2.x Sep 26, 2024
34 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants