[Backport 2.x] Run IT tests with security plugin (#335) #1986 #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Run IT tests with security plugin (#335) * Add extra IT flow. Signed-off-by: Yury-Fridlyand <[email protected]> * Remove unneeded files. Signed-off-by: Yury-Fridlyand <[email protected]> * Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix GHA matrix syntax. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix GHA matrix syntax. Signed-off-by: Yury-Fridlyand <[email protected]> * Code clean up. Signed-off-by: Yury-Fridlyand <[email protected]> * Optimize downloading. Signed-off-by: Yury-Fridlyand <[email protected]> * Apply suggestions from code review Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * Update integ-test/build.gradle Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Rework implementation. Signed-off-by: Yury-Fridlyand <[email protected]> * Address PR review. Signed-off-by: Yury-Fridlyand <[email protected]> * Address PR feedback + some fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * Minor fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Address PR feedback. Signed-off-by: Yury-Fridlyand <[email protected]> * Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> (cherry picked from commit 7e3a718) Signed-off-by: Yury-Fridlyand <[email protected]>
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Yury-Fridlyand
approved these changes
Aug 23, 2023
acarbonetto
approved these changes
Aug 23, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #2022 +/- ##
=========================================
Coverage 97.33% 97.33%
Complexity 4659 4659
=========================================
Files 408 408
Lines 12100 12100
Branches 830 830
=========================================
Hits 11778 11778
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #1986 to 2.x
This PR adds a new IT gradle task: integTestWithSecurity. It starts a cluster with security plugin installed (it takes latest snapshot), configures cluster, http client for tests and runs one test which required to be run with security plugin.
A new GHA is added which runs this test task.
Please, see team review and discussion in Bit-Quill#335.
Issues Resolved
fixes #1713
Check List
New functionality includes testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.