-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warning for GET/POST/PUT cache #4776
base: 2.x
Are you sure you want to change the base?
Conversation
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are instead trying to Deprecate the routes itself, you can do something like this:
waiting for deprecatedroute to be added
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #4776 +/- ##
=======================================
Coverage 65.44% 65.44%
=======================================
Files 319 319
Lines 22250 22251 +1
Branches 3591 3592 +1
=======================================
+ Hits 14561 14562 +1
Misses 5888 5888
Partials 1801 1801
|
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
new DeprecatedRoute( | ||
Method.GET, | ||
"/cache", | ||
"GET is not supported for /cache endpoint and will be removed in the next major version." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"GET is not supported for /cache endpoint and will be removed in the next major version." | |
"GET is not supported for /cache endpoint and will be removed in the next major version. Use DELETE instead." |
Description
Adds deprecation warning that GET/POST/PUT methods for cache endpoint is removed in version 3.0.0.
Issues Resolved
None
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failed
label from the original PR.No
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No
Testing
None
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.