Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for GET/POST/PUT cache #4776

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from

Conversation

derek-ho
Copy link
Contributor

@derek-ho derek-ho commented Oct 3, 2024

Description

Adds deprecation warning that GET/POST/PUT methods for cache endpoint is removed in version 3.0.0.

Issues Resolved

None
Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.
No

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No

Testing

None

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
DarshitChanpura
DarshitChanpura previously approved these changes Oct 3, 2024
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DarshitChanpura DarshitChanpura dismissed their stale review October 3, 2024 20:47

waiting for deprecatedroute to be added

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.44%. Comparing base (777fb59) to head (7f39b07).
Report is 2 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x    #4776   +/-   ##
=======================================
  Coverage   65.44%   65.44%           
=======================================
  Files         319      319           
  Lines       22250    22251    +1     
  Branches     3591     3592    +1     
=======================================
+ Hits        14561    14562    +1     
  Misses       5888     5888           
  Partials     1801     1801           
Files with missing lines Coverage Δ
...ch/security/dlic/rest/api/FlushCacheApiAction.java 65.38% <ø> (ø)

... and 6 files with indirect coverage changes

new DeprecatedRoute(
Method.GET,
"/cache",
"GET is not supported for /cache endpoint and will be removed in the next major version."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"GET is not supported for /cache endpoint and will be removed in the next major version."
"GET is not supported for /cache endpoint and will be removed in the next major version. Use DELETE instead."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants