Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging for version increment automation #1933

Closed
wants to merge 1 commit into from

Conversation

prudhvigodithi
Copy link
Contributor

@prudhvigodithi prudhvigodithi commented Jul 10, 2022

Signed-off-by: pgodithi [email protected]

Description

This is the staging PR for to execute workflows that auto raise the version increment PR's
Example: prudhvigodithi#2

  • Category: Enhancement

Issues Resolved

Part of: opensearch-project/opensearch-build#1375
From solution: opensearch-project/opensearch-build#1375 (comment)
Related issue: #1930

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Example: prudhvigodithi#2

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi prudhvigodithi requested a review from a team July 10, 2022 22:56
@prudhvigodithi prudhvigodithi added the backport 1.3 backport to 1.3 branch label Jul 10, 2022
@prudhvigodithi
Copy link
Contributor Author

Referred old 1.x version increment PR: https://github.com/opensearch-project/security/pull/1931/files
@dblock @bbarani

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #1933 (cc5b0da) into 1.x (154cf69) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.x    #1933   +/-   ##
=========================================
  Coverage     64.60%   64.60%           
  Complexity     3214     3214           
=========================================
  Files           247      247           
  Lines         17356    17356           
  Branches       3083     3083           
=========================================
  Hits          11212    11212           
  Misses         4594     4594           
  Partials       1550     1550           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 154cf69...cc5b0da. Read the comment docs.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1.x build scripts in this repo do not follow standard plugin conventions. Before we merge this we should be sure the end to end follow is compatible. Lets do this in main before attempting to make a change into this branch.

@peternied
Copy link
Member

I am closing this PR in favor of #1932 being backported. Please let me know if you have other thoughts on how this work should be conducted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 backport to 1.3 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants