Incremented version to 2.0.1 #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zelin Hao <[email protected]>
peternied
previously approved these changes
Jun 9, 2022
davidlago
previously approved these changes
Jun 9, 2022
3 tasks
Signed-off-by: cliu123 <[email protected]>
cliu123
reviewed
Jun 10, 2022
| @@ -341,8 +341,6 @@ private void checkAllSfAllowed() throws Exception { | |||
| rh.sendAdminCertificate = false; | |||
| checkReadAccess(HttpStatus.SC_OK, "picard", "picard", "sf", "_doc", 1); | |||
| checkWriteAccess(HttpStatus.SC_OK, "picard", "picard", "sf", "_doc", 1); | |||
| // ES7 only supports one doc type, so trying to create a second one leads to 400 BAD REQUEST | |||
| checkWriteAccess(HttpStatus.SC_BAD_REQUEST, "picard", "picard", "sf", "public", 1); | |||
There was a problem hiding this comment.
Removing this assertion to align with the behavior change in OpenSearch 2.0.1.
cliu123
reviewed
Jun 10, 2022
| @@ -213,12 +213,12 @@ protected String checkReadAccess(int status, String username, String password, S | |||
|
|
|||
| } | |||
|
|
|||
| protected String checkWriteAccess(int status, String username, String password, String indexName, String type, | |||
| protected String checkWriteAccess(int status, String username, String password, String indexName, String actionType, | |||
There was a problem hiding this comment.
Fixing the naming here as OpenSearch 2.0+ supports actionType in the API path and dropped the support for type.
Codecov Report
@@ Coverage Diff @@
## 2.0 #1881 +/- ##
============================================
- Coverage 60.85% 60.84% -0.02%
+ Complexity 3188 3187 -1
============================================
Files 253 253
Lines 17921 17921
Branches 3203 3203
============================================
- Hits 10906 10904 -2
- Misses 5439 5442 +3
+ Partials 1576 1575 -1
Continue to review full report at Codecov.
|
cliu123
approved these changes
Jun 10, 2022
|
@cliu123 Thanks for the help here! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zelin Hao [email protected]
Description
[Describe what this change achieves]
Increment version to 2.0.1
Part of opensearch-project/opensearch-build#2165
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.