Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth failure listener page with basic get, delete dummy create #2086

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

derek-ho
Copy link
Collaborator

Description

[Describe what this change achieves]

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@derek-ho
Copy link
Collaborator Author

Based on work here: opensearch-project/security#4641

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Project coverage is 70.71%. Comparing base (76c176a) to head (e031d80).
Report is 3 commits behind head on main.

Files Patch % Lines
...ps/configuration/panels/auth-failure-listeners.tsx 0.00% 14 Missing ⚠️
public/apps/configuration/app-router.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2086      +/-   ##
==========================================
- Coverage   71.17%   70.71%   -0.46%     
==========================================
  Files          96       97       +1     
  Lines        2598     2616      +18     
  Branches      387      387              
==========================================
+ Hits         1849     1850       +1     
- Misses        649      666      +17     
  Partials      100      100              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant