Add interfaces and models for rule engine #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chase Engelbrecht <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
engechas
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
goyamegh and
riysaxen-amzn
as code owners
Signed-off-by: Chase Engelbrecht <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
|
Plz create a meta and an issue explaining what is this change for and what are the changes to follow to set up the context for reviewers. |
Done, created #993 and subtasks |
eirsep
reviewed
Apr 25, 2024
|
|
||
| dependencies { | ||
| implementation rootProject | ||
| implementation "com.github.seancfoley:ipaddress:5.4.1" |
There was a problem hiding this comment.
Is this a veritable dependency or can we use a dependency already used in core.
There was a problem hiding this comment.
This is needed for CIDR range matching which will be introduced in the next PR. Alerting takes a dependency on the same module (but Security Analytics doesn't): https://github.com/opensearch-project/alerting/blob/main/alerting/build.gradle#L116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bootstraps the rule engine by adding the interfaces and common models
Issues
#993
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.