Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correlation alerts #877

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Mar 2, 2024

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Surya Sashank Nistala <[email protected]>
"correlation_id": {
"type": "keyword"
},
"correlation_rule_name": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be correlation_rule_names? to remain consistent with CorrelationAlert

Signed-off-by: Surya Sashank Nistala <[email protected]>
Copy link
Collaborator

@riysaxen-amzn riysaxen-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

correlation_id": {
        "type": "nested",
        "properties": {
         "correlation_rule_ids": {
            "type": "keyword"
          },
          "correlation_rule_names": {
            "type": "keyword"
          }
      }
}

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 264 lines in your changes are missing coverage. Please review.

Project coverage is 24.30%. Comparing base (8ef0a3f) to head (1848d8c).
Report is 1 commits behind head on main.

Files Patch % Lines
...arch/securityanalytics/model/CorrelationAlert.java 0.00% 206 Missing ⚠️
...ics/correlation/alert/CorrelationAlertService.java 0.00% 52 Missing ⚠️
...ytics/correlation/alert/CorrelationAlertsList.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #877      +/-   ##
============================================
- Coverage     24.82%   24.30%   -0.52%     
+ Complexity     1030     1029       -1     
============================================
  Files           277      280       +3     
  Lines         12717    12966     +249     
  Branches       1401     1420      +19     
============================================
- Hits           3157     3152       -5     
- Misses         9296     9550     +254     
  Partials        264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Surya Sashank Nistala <[email protected]>
this.xContentRegistry = xContentRegistry;
}

public void getCorrelationAlerts(ActionListener<CorrelationAlertsList> listener,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we move the ActionListener as the last parameter for consistency?

Signed-off-by: Surya Sashank Nistala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants