-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring Search Pipeline Update and Add IgnoreFailure and PipelineContext To Each Processors #152
Bring Search Pipeline Update and Add IgnoreFailure and PipelineContext To Each Processors #152
Conversation
...relevance/transformer/personalizeintelligentranking/PersonalizeRankingResponseProcessor.java
Show resolved
Hide resolved
...ava/org/opensearch/search/relevance/configuration/ResultTransformerConfigurationFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mingshi Liu <[email protected]>
97b1a09
to
c694adb
Compare
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
=========================================
Coverage 83.41% 83.41%
Complexity 324 324
=========================================
Files 41 41
Lines 1242 1242
Branches 152 152
=========================================
Hits 1036 1036
Misses 130 130
Partials 76 76
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some nitpicks. I'm not sure if we have a linter on this repo, but we should consider using one to match some of the spacings (some parameters have spaces between comments and some don't, not sure what convention to stick to).
.../relevance/transformer/kendraintelligentranking/pipeline/KendraRankingResponseProcessor.java
Outdated
Show resolved
Hide resolved
.../relevance/transformer/kendraintelligentranking/pipeline/KendraRankingResponseProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mingshi Liu <[email protected]>
Good idea, I checked all the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-152-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c15274e83c425197b3cfdcf9f5c487d37d9f733b
# Push it to GitHub
git push --set-upstream origin backport/backport-152-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* Add ignoreFailure and pipelineContext Signed-off-by: Mingshi Liu <[email protected]> * use lowercase Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit c15274e)
* Add ignoreFailure and pipelineContext Signed-off-by: Mingshi Liu <[email protected]> * use lowercase Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit c15274e)
* Add ignoreFailure and pipelineContext Signed-off-by: Mingshi Liu <[email protected]> * use lowercase Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit c15274e) Signed-off-by: Mingshi Liu <[email protected]>
* Add ignoreFailure and pipelineContext * use lowercase --------- (cherry picked from commit c15274e) Signed-off-by: Mingshi Liu <[email protected]>
Description
Add ignoreFailure and pipelineContext
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.