Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle to use isSnapshot logic #521

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

khushbr
Copy link
Collaborator

@khushbr khushbr commented Nov 17, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Addresses build failure seen for 2.11.1: https://github.com/opensearch-project/performance-analyzer-rca/actions/runs/6899471514/job/18771262101#step:11:33

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Execution failed for task ':updateShas'.
> Could not resolve all dependencies for configuration ':runtimeClasspath'.
   > Conflict(s) found for the following module(s):
       - org.apache.logging.log4j:log4j-api between versions 2.21.0 and 2.20.0
       - org.apache.logging.log4j:log4j-core between versions 2.21.0 and 2.20.0
     Run with:
         --scan or
         :dependencyInsight --configuration runtimeClasspath --dependency org.apache.logging.log4j:log4j-api
     to get more insight on how to solve the conflict.

Check List

  • Backport Labels added.
  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ansjcy
ansjcy previously approved these changes Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b86f6e3) 75.74% compared to head (ca48146) 75.67%.

❗ Current head ca48146 differs from pull request most recent head 8d36b95. Consider uploading reports for the commit 8d36b95 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               2.11     #521      +/-   ##
============================================
- Coverage     75.74%   75.67%   -0.08%     
+ Complexity     2584     2581       -3     
============================================
  Files           303      303              
  Lines         15415    15415              
  Branches       1218     1218              
============================================
- Hits          11676    11665      -11     
- Misses         3250     3260      +10     
- Partials        489      490       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansjcy ansjcy merged commit a9f4486 into opensearch-project:2.11 Nov 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants