use mavenLocal as the first entry in repositories section #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chenyang Ji <[email protected]>
ansjcy
requested review from
praveensameneni,
khushbr,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
khushbr
previously approved these changes
Jul 10, 2023
AWSHurneyt
approved these changes
Jul 10, 2023
sbcd90
approved these changes
Jul 10, 2023
khushbr
approved these changes
Jul 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
Signed-off-by: Chenyang Ji <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> (cherry picked from commit 3a70620)
khushbr
pushed a commit
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Chenyang Ji <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> (cherry picked from commit 3a70620) Co-authored-by: Chenyang Ji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
This PR resolves the first action item in #432, to use mavenLocal as the first entry in repositories section, to ensure that when core/min dependencies are published to maven local, gradle looks at maven local first and gets the required core/min dependencies rather than fetching from snapshots or maven central resulting in false checks.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.