Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename com.rfs through the codebase to org.opensearch.migrations.bulkload #997

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gregschohn
Copy link
Collaborator

Description

CreateSnapshot & RfsMigrateDocuments both live under org.opensearch.migrations (not bulkload) to match parity with MetadataMigration and since CreateSnapshot isn't really a bulkload thing. I've also renamed the cms directory (also under ...bulkload) to workcoordination. Some of the recent changes for SonarLint appeasement have been reverted as they created some compilation errors (visibility of classes across packages). The old code was safer, if terser, anyway. Further directory/package reorganizations would be beneficial, as would unifying structures w/ the replayer and capture proxy code, but those can be for later. For now, the main goal of this commit is to sanitize the package names to be something that the maintainers of this project control.

  • Category Refactoring
  • Why these changes are required? To publish our packages with names that we own and control.
  • What is the old behavior before changes and new behavior after changes? There should be no user-facing change.

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-2020

Testing

Just gradle testing. I'm hoping to look at Jenkins pipelines shortly.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…load.

CreateSnapshot & RfsMigrateDocuments both live under org.opensearch.migrations (not bulkload) to match parity with MetadataMigration and since CreateSnapshot isn't really a bulkload thing.
I've also renamed the cms directory (also under ...bulkload) to workcoordination.
Some of the recent changes for SonarLint appeasement have been reverted as they created some compilation errors (visibility of classes across packages).  The old code was safer, if terser, anyway.
Further directory/package reorganizations would be beneficial, as would unifying structures w/ the replayer and capture proxy code, but those can be for later.  For now, the main goal of this commit is to sanitize the package names to be something that the maintainers of this project control.

Signed-off-by: Greg Schohn <[email protected]>
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.05%. Comparing base (d99beb6) to head (85a40b0).

Files with missing lines Patch % Lines
...org/opensearch/migrations/RfsMigrateDocuments.java 53.84% 5 Missing and 1 partial ⚠️
...h/migrations/bulkload/common/OpenSearchClient.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #997      +/-   ##
============================================
+ Coverage     78.98%   79.05%   +0.06%     
+ Complexity     2723     2720       -3     
============================================
  Files           375      375              
  Lines         13869    13855      -14     
  Branches        970      969       -1     
============================================
- Hits          10955    10953       -2     
+ Misses         2340     2326      -14     
- Partials        574      576       +2     
Flag Coverage Δ
gradle-test 76.87% <53.33%> (+0.07%) ⬆️
python-test 89.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant