Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Console Status Printing #768

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Jun 25, 2024

Description

Makes some improvements and fixes for the console printing.
The logic had a bug that didn't parse the response correctly.

  • Category: Enhancement
  • Why these changes are required? Currently status deep check not working
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Manual testing and unit tests added

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.51%. Comparing base (91c64bd) to head (a978c0a).
Report is 1 commits behind head on main.

Current head a978c0a differs from pull request most recent head ab5915b

Please upload reports for the commit ab5915b to get more accurate results.

Files Patch % Lines
...src/main/java/com/rfs/common/OpenSearchClient.java 0.00% 5 Missing ⚠️
...le/lib/console_link/console_link/logic/clusters.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #768      +/-   ##
============================================
+ Coverage     68.44%   68.51%   +0.07%     
- Complexity     1576     1578       +2     
============================================
  Files           275      275              
  Lines         11592    11596       +4     
  Branches        734      735       +1     
============================================
+ Hits           7934     7945      +11     
+ Misses         3253     3248       -5     
+ Partials        405      403       -2     
Flag Coverage Δ
gradle-test 61.34% <0.00%> (+0.07%) ⬆️
python-test 87.37% <60.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait force-pushed the UpdatePrinting branch 4 times, most recently from 64876b8 to 36ae8c9 Compare June 25, 2024 21:35
@AndreKurait AndreKurait marked this pull request as ready for review June 25, 2024 21:48
@AndreKurait AndreKurait force-pushed the UpdatePrinting branch 2 times, most recently from b76db0e to fefb70f Compare June 25, 2024 22:02
@AndreKurait AndreKurait force-pushed the UpdatePrinting branch 2 times, most recently from a978c0a to ab5915b Compare June 26, 2024 03:58
@AndreKurait AndreKurait merged commit 3fec905 into opensearch-project:main Jun 26, 2024
20 of 22 checks passed
@AndreKurait AndreKurait deleted the UpdatePrinting branch June 26, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants