Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Scale for ECS services; replayer start/stop #765

Conversation

mikaylathompson
Copy link
Collaborator

Description

  • Adds a Replayer model and the CLI commands to interact with it
  • Implements ECS replayer commands for start, stop, and scale
  • Adds replayer yaml to the CDK (with a default scale of 1 -- we should eventually add a context field to control this)
  • Adds scale command for RFS on ECS

Issues Resolved

Kind of a lot of them, because of how I broke down the replayer work:
https://opensearch.atlassian.net/browse/MIGRATIONS-1773
https://opensearch.atlassian.net/browse/MIGRATIONS-1774
https://opensearch.atlassian.net/browse/MIGRATIONS-1775
(these will truly be completed when the documentation is in place)

Testing

Unit tests, manually tested on ECS deployment

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 54.16667% with 77 lines in your changes missing coverage. Please review.

Project coverage is 68.48%. Comparing base (32b0d9f) to head (17e0c6a).
Report is 1 commits behind head on main.

Files Patch % Lines
...sole/lib/console_link/console_link/logic/replay.py 19.04% 51 Missing ⚠️
...rationConsole/lib/console_link/console_link/cli.py 51.28% 19 Missing ⚠️
.../console_link/console_link/models/replayer_base.py 83.87% 5 Missing ⚠️
...nsole/lib/console_link/console_link/environment.py 90.00% 1 Missing ⚠️
...b/console_link/console_link/models/replayer_ecs.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #765      +/-   ##
============================================
+ Coverage     68.46%   68.48%   +0.01%     
+ Complexity     1577     1576       -1     
============================================
  Files           273      275       +2     
  Lines         11454    11587     +133     
  Branches        734      734              
============================================
+ Hits           7842     7935      +93     
- Misses         3209     3249      +40     
  Partials        403      403              
Flag Coverage Δ
gradle-test 61.32% <ø> (+0.02%) ⬆️
python-test 87.31% <54.16%> (-0.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikaylathompson mikaylathompson force-pushed the console-lib-replayer-start-stop branch from 6f08034 to 6cb5905 Compare June 25, 2024 17:24
ReplayStatus = Enum("ReplayStatus", ["NOT_STARTED", "RUNNING", "STOPPED", "FAILED"])


class Replayer(ABC):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice way to inject this abstraction

Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
@mikaylathompson mikaylathompson merged commit f6da3bc into opensearch-project:main Jun 25, 2024
11 of 13 checks passed
@mikaylathompson mikaylathompson deleted the console-lib-replayer-start-stop branch June 25, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants