Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Make changes for filesystem snapshots #755

Conversation

mikaylathompson
Copy link
Collaborator

@mikaylathompson mikaylathompson commented Jun 21, 2024

Description

Console library support for the Java changes in #754.

Supports snapshot descriptions like:

snapshot:
  snapshot_name: "snapshot_2023_01_01"
  s3:
    repo_uri: "s3://os-demo-us-east-1-snapshots/2024-06-20-snapshot-test-0001/"
    aws_region: "us-east-1"

or

snapshot:
  snapshot_name: "snapshot_2023_01_01"
  fs:
    repo_path: "/snapshot/test"

Tests are fixed up (and a number are added), includes CDK support, etc.

Issues Resolved

n/a

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.35%. Comparing base (bdede49) to head (2be3d70).
Report is 1 commits behind head on main.

Files Patch % Lines
...e/lib/console_link/console_link/models/snapshot.py 90.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #755      +/-   ##
============================================
+ Coverage     68.18%   68.35%   +0.17%     
  Complexity     1577     1577              
============================================
  Files           270      270              
  Lines         11139    11175      +36     
  Branches        736      736              
============================================
+ Hits           7595     7639      +44     
+ Misses         3141     3133       -8     
  Partials        403      403              
Flag Coverage Δ
gradle-test 61.48% <ø> (+0.01%) ⬆️
python-test 88.87% <91.48%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
@mikaylathompson mikaylathompson force-pushed the console-lib-snapshot-for-filesystem branch from 428674a to 293ab14 Compare June 24, 2024 05:35
snapshot:
snapshot_name: "snapshot_2023_01_01"
s3_repo_uri: "s3://my-snapshot-bucket"
s3_region: "us-east-2"
s3:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have the fs keys to make snapshots with docker solution?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yep, definitely. Fixing now.

@mikaylathompson mikaylathompson force-pushed the console-lib-snapshot-for-filesystem branch from d18c737 to 2be3d70 Compare June 24, 2024 16:55
@mikaylathompson mikaylathompson merged commit 179aef1 into opensearch-project:main Jun 24, 2024
12 of 13 checks passed
@mikaylathompson mikaylathompson deleted the console-lib-snapshot-for-filesystem branch June 25, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants