Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FetchMigration build #753

Merged

Conversation

AndreKurait
Copy link
Member

Description

Fix FetchMigration build

  • Category: Bug Fix
  • Why these changes are required? Error below
  • What is the old behavior before changes and new behavior after changes? See error code below, with change, no error

Issues Resolved

Currently getting

#10 [ 6/10] RUN pipenv install --system --deploy --ignore-pipfile
#10 1.257 Usage: pipenv install [OPTIONS] [PACKAGES]...
#10 1.257 
#10 1.257 ERROR:: --system is intended to be used for Pipfile installation, not installation of specific packages. Aborting.
#10 1.257 See also: --deploy flag.
#10 ERROR: process "/bin/sh -c pipenv install --system --deploy --ignore-pipfile" did not complete successfully: exit code: 2
------
 > [ 6/10] RUN pipenv install --system --deploy --ignore-pipfile:
1.257 Usage: pipenv install [OPTIONS] [PACKAGES]...
1.257 
1.257 ERROR:: --system is intended to be used for Pipfile installation, not installation of specific packages. Aborting.
1.257 See also: --deploy flag.
------
Dockerfile:8
--------------------
   6 |     RUN apt -y install python3 python3-pip
   7 |     RUN pip3 install pipenv
   8 | >>> RUN pipenv install --system --deploy --ignore-pipfile
   9 |     
  10 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c pipenv install --system --deploy --ignore-pipfile" did not complete successfully: exit code: 2

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Ran build

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.21%. Comparing base (787fd26) to head (4ed4450).
Report is 6 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #753       +/-   ##
=============================================
- Coverage     89.37%   68.21%   -21.17%     
- Complexity        0     1579     +1579     
=============================================
  Files            46      270      +224     
  Lines          2702    11139     +8437     
  Branches          0      736      +736     
=============================================
+ Hits           2415     7598     +5183     
- Misses          287     3140     +2853     
- Partials          0      401      +401     
Flag Coverage Δ
gradle-test 61.50% <ø> (?)
python-test 88.47% <ø> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, looks like we are missing attempting to build the fetch migration cluster in our GHA, can you please add a check that would build this image?

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndreKurait AndreKurait merged commit d1e3865 into opensearch-project:main Jun 21, 2024
12 of 13 checks passed
@AndreKurait AndreKurait deleted the FixFetchMigrationBuild branch June 21, 2024 23:04
@AndreKurait AndreKurait mentioned this pull request Jun 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants