Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 3.0.0 manifest file for dashboards-notifications #3092

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Jan 11, 2023

Signed-off-by: Chenyang Ji [email protected]

Description

Since we already moved dashboards-notifications to its own repo, we need to update the 3.0.0 manifest file as well to reflect the change.

Issues Resolved

opensearch-project/dashboards-notifications#4
opensearch-project/notifications#466

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ansjcy ansjcy requested a review from a team as a code owner January 11, 2023 22:22
@gaiksaya
Copy link
Member

Hi @ansjcy ,

Can you fix the lint error? Needs a new line at the end

@ansjcy ansjcy force-pushed the update-3.0.0-manifest-file-for-notifications branch from 5c7f5d7 to 5330313 Compare January 12, 2023 18:56
@ansjcy
Copy link
Member Author

ansjcy commented Jan 12, 2023

@gaiksaya Thanks for noticing! just updated the PR.

@gaiksaya gaiksaya merged commit 15fc8c9 into opensearch-project:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants