Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require response bodies in tests. #502

Closed
wants to merge 1 commit into from

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 13, 2024

Description

Require response bodies in tests.

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock added the skip-changelog No need to update CHANGELOG. label Aug 13, 2024
Copy link

github-actions bot commented Aug 13, 2024

Changes Analysis

Commit SHA: b7686a4
Comparing To SHA: 42fd4d7

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10370202042/artifacts/1806527436

API Coverage

Before After Δ
Covered (%) 522 (51.13 %) 522 (51.13 %) 0 (0 %)
Uncovered (%) 499 (48.87 %) 499 (48.87 %) 0 (0 %)
Unknown 26 26 0

Copy link

Spec Test Coverage Analysis

Total Tested
548 209 (38.14 %)

@nhtruong
Copy link
Collaborator

#496 refers to missing explicit response body definition in the spec. In the test we don't need to explicitly specify a response body per chapter because it's assumed to be the default 200 - application/json as it applies to 99% of test cases.

@dblock
Copy link
Member Author

dblock commented Aug 13, 2024

Oh I see. I removed "closes ..." from the PR, I think this still can be merged, yes? I think requiring an explicit expectation makes sense, most of our tests do.

I'll just close.

@dblock dblock closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants