Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove job scheduler #1560

Merged
merged 8 commits into from
Jun 29, 2023
Merged

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Jun 27, 2023

Description

Bump bwc version to 2.9 to unblock CI. Removes job scheduler dependency since it is not used

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@YANG-DB
Copy link
Member

YANG-DB commented Jun 28, 2023

nice - 👍

@derek-ho derek-ho merged commit 4e0ca5a into opensearch-project:main Jun 29, 2023
16 of 19 checks passed
@derek-ho derek-ho deleted the remote-job-scheduler branch June 29, 2023 14:14
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1560-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4e0ca5ab59747d84c14441db0973fbc2a0dc5574
# Push it to GitHub
git push --set-upstream origin backport/backport-1560-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1560-to-2.x.

derek-ho added a commit to derek-ho/observability that referenced this pull request Jun 29, 2023
* remove job scheduler

Signed-off-by: Derek Ho <[email protected]>

* remove job scheduler files and build.gradle

Signed-off-by: Derek Ho <[email protected]>

* ktlint

Signed-off-by: Derek Ho <[email protected]>

* add back job scheduler to fix bwc

Signed-off-by: Derek Ho <[email protected]>

* remove job scheduler and add it back for older version

Signed-off-by: Derek Ho <[email protected]>

* remove job scheduler in prepare Bwc Tests

Signed-off-by: Derek Ho <[email protected]>

* bump bwc version

Signed-off-by: Derek Ho <[email protected]>

* add todo of removing job scheduler things after 2.9 release

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 4e0ca5a)
Signed-off-by: Derek Ho <[email protected]>
derek-ho added a commit that referenced this pull request Jul 14, 2023
* remove job scheduler



* remove job scheduler files and build.gradle



* ktlint



* add back job scheduler to fix bwc



* remove job scheduler and add it back for older version



* remove job scheduler in prepare Bwc Tests



* bump bwc version



* add todo of removing job scheduler things after 2.9 release



---------


(cherry picked from commit 4e0ca5a)

Signed-off-by: Derek Ho <[email protected]>
derek-ho added a commit that referenced this pull request Aug 1, 2023
* remove job scheduler (#1560)

* remove job scheduler

Signed-off-by: Derek Ho <[email protected]>

* remove job scheduler files and build.gradle

Signed-off-by: Derek Ho <[email protected]>

* ktlint

Signed-off-by: Derek Ho <[email protected]>

* add back job scheduler to fix bwc

Signed-off-by: Derek Ho <[email protected]>

* remove job scheduler and add it back for older version

Signed-off-by: Derek Ho <[email protected]>

* remove job scheduler in prepare Bwc Tests

Signed-off-by: Derek Ho <[email protected]>

* bump bwc version

Signed-off-by: Derek Ho <[email protected]>

* add todo of removing job scheduler things after 2.9 release

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 4e0ca5a)
Signed-off-by: Derek Ho <[email protected]>

* Resolve build issue (#1572)

* resolve dependency issues

Signed-off-by: Eric <[email protected]>

* resolve jacocoagent missing issue

Signed-off-by: Eric <[email protected]>

* bump up build.gradle

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Eric <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
(cherry picked from commit 4345041)
Signed-off-by: Derek Ho <[email protected]>

* try get older common utils

Signed-off-by: Derek Ho <[email protected]>

* revert back

Signed-off-by: Derek Ho <[email protected]>

* revert kotlin version change

Signed-off-by: Derek Ho <[email protected]>

* additional core changes

Signed-off-by: Derek Ho <[email protected]>

* update import orderings

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Eric <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants