Feature alerting mail support html format #586 #614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankyalo599
force-pushed
the
_FEATURE_Alerting_mail_support_html_format_#586
branch
from
e10c4f1
to
e2a4e4f
Compare
Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Chenyang Ji <[email protected]> Co-authored-by: Chenyang Ji <[email protected]> Signed-off-by: danielkyalo599 <[email protected]>
…stom webhook to select message Signed-off-by: danielkyalo599 <[email protected]>
…stom webhook to select message Signed-off-by: danielkyalo599 <[email protected]>
Signed-off-by: danielkyalo599 <[email protected]>
dankyalo599
force-pushed
the
_FEATURE_Alerting_mail_support_html_format_#586
branch
from
d1f59a9
to
893e378
Compare
lezzago
reviewed
Feb 16, 2023
| @@ -153,7 +153,7 @@ jobs: | |||
| uses: actions/cache@v2 | |||
| with: | |||
| path: ${{ matrix.cypress_cache_folder }} | |||
| key: cypress-cache-v2-${{ runner.os }}-${{ hashFiles('**/package.json') }} | |||
| key: cypress-cache-v2-${{ runner.os }}-${{ hashFiles('OpenSearch-Dashboards/plugins/dashboards-notifications/package.json') }} | |||
lezzago
reviewed
Feb 16, 2023
| @@ -8,5 +8,5 @@ package org.opensearch.notifications.spi.model.destination | |||
| * Supported notification destinations | |||
| */ | |||
| enum class DestinationType { | |||
| CHIME, SLACK, CUSTOM_WEBHOOK, SMTP, SES, SNS | |||
| CHIME, SLACK, CUSTOM_WEBHOOK, SMTP, SES, SNS, TELEGRAM | |||
There was a problem hiding this comment.
remove telegram from this PR as its part of another pr
|
Please provide screen shots of the html support working. |
|
Repeated PR, close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature alerting mail support html format #586
Issues Resolved
To make the MessageContent class support HTML format for email notifications,I modified the buildMessageWithTitle method to take into account the htmlDescription property.
With this change, the method will return the htmlDescription property if it is not null, otherwise it will return the concatenation of the title and text description as before.
Furthermore , I modified the init block to check if the htmlDescription property is not null, since it's no longer required.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.