Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. #823

Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 8, 2024

Coming from opensearch-project/opensearch-api-specification#387, update PR template to include a checkbox that requests that all API changes be documented in the OpenAPI spec used to generate clients.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@martin-gaievski martin-gaievski added backport 2.x Label will add auto workflow to backport PR to 2.x branch Infrastructure labels Jul 25, 2024
@martin-gaievski martin-gaievski merged commit 1f27491 into opensearch-project:main Jul 25, 2024
99 of 117 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 25, 2024
martin-gaievski pushed a commit that referenced this pull request Jul 26, 2024
…cklist. (#823) (#850)

Signed-off-by: dblock <[email protected]>
(cherry picked from commit 1f27491)

Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
@dblock dblock deleted the update-pull-request-template branch July 29, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch Infrastructure skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants