Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update document with knnn_vector size not matching issue #212

Merged

Conversation

zane-neo
Copy link
Collaborator

Description

This PR fixed the issue when updating a document with knn_vector field, the update fails because the vector dimension is not matching the required dimension.

Issues Resolved

#207

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #212 (e4e24d4) into main (e77370e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #212   +/-   ##
=========================================
  Coverage     89.55%   89.55%           
  Complexity      103      103           
=========================================
  Files             7        7           
  Lines           316      316           
  Branches         52       52           
=========================================
  Hits            283      283           
  Misses           16       16           
  Partials         17       17           
Impacted Files Coverage Δ
...neuralsearch/processor/TextEmbeddingProcessor.java 92.85% <100.00%> (ø)

@zane-neo zane-neo merged commit ca29bce into opensearch-project:main Jul 12, 2023
18 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes Changes to a system or product designed to handle a programming bug/glitch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants