Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Update Default Rescore Context based on Dimension (#2149) (#2150) #2152

Open
wants to merge 4 commits into
base: 2.17
Choose a base branch
from

Conversation

naveentatikonda
Copy link
Member

(cherry picked from commit a1227ea)
Signed-off-by: Naveen Tatikonda [email protected]

Co-authored-by: Vikasht34 [email protected]
(cherry picked from commit db37c93)

(cherry picked from commit a1227ea)
Signed-off-by: Naveen Tatikonda <[email protected]>

Co-authored-by: Vikasht34 <[email protected]>
(cherry picked from commit db37c93)
ryanbogan
ryanbogan previously approved these changes Sep 26, 2024
@ryanbogan
Copy link
Member

Looks like spotless is failing

Signed-off-by: Naveen Tatikonda <[email protected]>
@naveentatikonda naveentatikonda changed the title Update Default Rescore Context based on Dimesion (#2149) (#2150) [Backport 2.17] Update Default Rescore Context based on Dimesion (#2149) (#2150) Sep 27, 2024
@naveentatikonda naveentatikonda changed the title [Backport 2.17] Update Default Rescore Context based on Dimesion (#2149) (#2150) [Backport 2.17] Update Default Rescore Context based on Dimension (#2149) (#2150) Sep 27, 2024
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@naveentatikonda
Copy link
Member Author

naveentatikonda commented Sep 27, 2024

Pls hold and don't merge until confirmed by build team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants