Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed JDK 11 and 17 version from CI runs #1921

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

navneet1v
Copy link
Collaborator

Description

Removed JDK 11 and 17 version from CI runs as main branch is moved to higher versions of JDK. I didn't make changes in the target and source compatibility because there is some other issues I am seeing for micro-benchmarks module. Will try to resolve it and then raise another PR for the same.

Related Issues

Ref: #1729

Check List

  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v navneet1v added the Maintenance Add support for new versions of OpenSearch/Dashboards from upstream label Aug 1, 2024
@jmazanec15
Copy link
Member

@navneet1v shall we backport or no? Maybe we can leave other versions for BWC, but for CI/sec for 2.x I think jdk 21 is fine

@navneet1v
Copy link
Collaborator Author

@navneet1v shall we backport or no? Maybe we can leave other versions for BWC, but for CI/sec for 2.x I think jdk 21 is fine

No we should not backport. Check this comment from @reta on neural search PR: opensearch-project/neural-search#838 (comment)

@navneet1v navneet1v merged commit 523c681 into opensearch-project:main Aug 2, 2024
29 checks passed
@reta
Copy link
Contributor

reta commented Aug 2, 2024

Correct, JDK-21 baseline is only for 3.x line (aka main)

Vikasht34 pushed a commit to Vikasht34/k-NN that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Add support for new versions of OpenSearch/Dashboards from upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants