Fix sed command in DEVELOPER_GUIDE to append a new line character '\n…

…'. (#2181) Signed-off-by: Dooyong Kim <[email protected]> Co-authored-by: Dooyong Kim <[email protected]>
opensearch-project · Oct 3, 2024 · 6771842 · 6771842
1 parent f3b2bd0
commit 6771842
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 ### Infrastructure
 * Removed JDK 11 and 17 version from CI runs [#1921](https://github.com/opensearch-project/k-NN/pull/1921)
 ### Documentation
+* Fix sed command in DEVELOPER_GUIDE.md to append a new line character '\n'. [#2181](https://github.com/opensearch-project/k-NN/pull/2181)
 ### Maintenance
 ### Refactoring
 * Does not create additional KNNVectorValues in NativeEngines990KNNVectorWriter when quantization is not needed [#2133](https://github.com/opensearch-project/k-NN/pull/2133)

diff --git a/DEVELOPER_GUIDE.md b/DEVELOPER_GUIDE.md
@@ -119,7 +119,8 @@ export CXX=/opt/homebrew/opt/llvm/bin/clang++
 // In case of linking issues with the external libraries and clang, you can try setting the CMAKE compiler to gcc/g++ instead through the following commands:
 export CC=gcc
 export CXX=g++
-sed -i '' '/set(CMAKE_CXX_STANDARD_REQUIRED True)/a\'$'\n''set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Xclang -fopenmp -L/opt/homebrew/opt/libomp/lib -I/opt/homebrew/opt/libomp/include -lomp -arch arm64 -fexceptions")' CMakeLists.txt
+sed -i '' '/set(CMAKE_CXX_STANDARD_REQUIRED True)/a\'$'\n''set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Xclang -fopenmp -L/opt/homebrew/opt/libomp/lib -I/opt/homebrew/opt/libomp/include -lomp -arch arm64 -fexceptions")'$'\n''' CMakeLists.txt
+
 
 // Build
 cmake . --fresh
@@ -478,4 +479,4 @@ The Github workflow in [`backport.yml`](.github/workflows/backport.yml) creates
 original PR with an appropriate label `backport <backport-branch-name>` is merged to main with the backport workflow 
 run successfully on the PR. For example, if a PR on main needs to be backported to `1.x` branch, add a label 
 `backport 1.x` to the PR and make sure the backport workflow runs on the PR along with other checks. Once this PR is 
-merged to main, the workflow will create a backport PR to the `1.x` branch.
+merged to main, the workflow will create a backport PR to the `1.x` branch.