Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing release notes path for 2.9 #432

Merged

Conversation

saratvemulapalli
Copy link
Member

@saratvemulapalli saratvemulapalli commented Jul 24, 2023

Description

Looks like 2.9 release notes were put in https://github.com/saratvemulapalli/job-scheduler/blob/main/release-notes/release-notes/opensearch.job-scheduler.release-notes-2.9.0.0.md which is why workflow failed to release it: https://github.com/opensearch-project/job-scheduler/actions/runs/5649165701/job/15302930573

Also fixed main build broken due to: opensearch-project/OpenSearch#8636

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
joshpalis
joshpalis previously approved these changes Jul 28, 2023
Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a rebase after the sample extension BWC version is bumped up to 2.10.0, BWC tests are currently failing due to main still using 2.9

@saratvemulapalli
Copy link
Member Author

This will need a rebase after the sample extension BWC version is bumped up to 2.10.0, BWC tests are currently failing due to main still using 2.9

Yup just rebased with main.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #432 (de0edff) into main (acae28c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #432   +/-   ##
=========================================
  Coverage     29.19%   29.19%           
  Complexity       98       98           
=========================================
  Files            22       22           
  Lines          1185     1185           
  Branches        109      109           
=========================================
  Hits            346      346           
  Misses          818      818           
  Partials         21       21           

@joshpalis joshpalis self-requested a review August 1, 2023 21:54
@vibrantvarun vibrantvarun merged commit dd23cc5 into opensearch-project:main Aug 1, 2023
13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 1, 2023
* Fixing release notes path

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Fixing main build

Signed-off-by: Sarat Vemulapalli <[email protected]>

---------

Signed-off-by: Sarat Vemulapalli <[email protected]>
(cherry picked from commit dd23cc5)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 1, 2023
* Fixing release notes path

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Fixing main build

Signed-off-by: Sarat Vemulapalli <[email protected]>

---------

Signed-off-by: Sarat Vemulapalli <[email protected]>
(cherry picked from commit dd23cc5)
vibrantvarun pushed a commit that referenced this pull request Aug 1, 2023
* Fixing release notes path

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Fixing main build

Signed-off-by: Sarat Vemulapalli <[email protected]>

---------

Signed-off-by: Sarat Vemulapalli <[email protected]>
(cherry picked from commit dd23cc5)

Co-authored-by: Sarat Vemulapalli <[email protected]>
vibrantvarun pushed a commit that referenced this pull request Aug 1, 2023
* Fixing release notes path

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Fixing main build

Signed-off-by: Sarat Vemulapalli <[email protected]>

---------

Signed-off-by: Sarat Vemulapalli <[email protected]>
(cherry picked from commit dd23cc5)

Co-authored-by: Sarat Vemulapalli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants