Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup QSQ follow-up #800

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

petardz
Copy link
Contributor

@petardz petardz commented May 30, 2023

Issue #, if available:

Description of changes:

To support QueryStringQuery queries we're using core's QueryStringQueryParser which requires us to have mappings of index(QueryShardContext --> MapperService) for which we're parsing query_string. In our case that is sourceIndex and since we want to support this type of query, even if sourceIndex is deleted, we need to store sourceIndex mappings inside rollup job. We can only store mappings for fields that we allow user to search on: all dimensions except DATE_HISTOGRAM field.

  1. Added saving of field mappings of sourceIndex fields of interest inside rollup job in sourceIndexFieldMappings field
  2. Added populating newly added field sourceIndexFieldMappings during Rollup Create/Update actions
  3. Added updating rollup job inside rollup index mapping _meta field from RollupInterceptor, to handle old rollup jobs created before this PR.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Petar Dzepina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant