Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #758

Closed
wants to merge 1 commit into from
Closed

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Apr 18, 2023

Issue #, if available:

Description of changes:

Fix flaky tests

  1. test stop rollup when multiple shards configured for IM config index
    https://github.com/opensearch-project/index-management/actions/runs/4725743322/jobs/8384526986?pr=755
  2. test history shard settings
    https://github.com/opensearch-project/index-management/actions/runs/4704146733/jobs/8343485330
  3. test stopping a failed rollup
    https://github.com/opensearch-project/index-management/actions/runs/4703947366/jobs/8343058989

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #758 (b34e6c9) into main (19fc44b) will increase coverage by 0.08%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #758      +/-   ##
============================================
+ Coverage     75.58%   75.67%   +0.08%     
- Complexity     2680     2682       +2     
============================================
  Files           337      337              
  Lines         15562    15562              
  Branches       2286     2286              
============================================
+ Hits          11763    11776      +13     
+ Misses         2462     2454       -8     
+ Partials       1337     1332       -5     

see 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: bowenlan-amzn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants