Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change test page size to avoid index/search TimeInMillis < 1 issue. #460

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Change test page size to avoid index/search TimeInMillis < 1 issue. #460

merged 2 commits into from
Aug 23, 2022

Conversation

Angie-Zhang
Copy link
Contributor

@Angie-Zhang Angie-Zhang commented Aug 10, 2022 •
edited by bowenlan-amzn
Loading

Signed-off-by: Angie Zhang [email protected]

Issue #, if available: #457

#90 (comment)

Description of changes: Change test page size to avoid indexTimeInMillis/searchTimeInMillis < 1 issue.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Angie-Zhang Angie-Zhang marked this pull request as ready for review August 10, 2022 01:50
@Angie-Zhang Angie-Zhang requested a review from a team August 10, 2022 01:50
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022 •
edited
Loading

Codecov Report

Merging #460 (85b1f3b) into main (a7fb77e) will increase coverage by 0.20%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #460      +/-   ##
============================================
+ Coverage     75.74%   75.94%   +0.20%     
- Complexity     2470     2475       +5     
============================================
  Files           314      314              
  Lines         14440    14440              
  Branches       2233     2233              
============================================
+ Hits          10938    10967      +29     
+ Misses         2250     2232      -18     
+ Partials       1252     1241      -11
Impacted Files Coverage Δ
...nt/indexstatemanagement/model/destination/Chime.kt 55.55% <0.00%> (-22.23%) ⬇️
...arch/indexmanagement/rollup/RollupSearchService.kt 57.40% <0.00%> (-3.71%) ⬇️
.../rollup/action/start/TransportStartRollupAction.kt 72.94% <0.00%> (-2.36%) ⬇️
...ent/indexstatemanagement/util/ManagedIndexUtils.kt 76.10% <0.00%> (-1.77%) ⬇️
...earch/indexmanagement/transform/model/Transform.kt 85.89% <0.00%> (+1.28%) ⬆️
...ndexstatemanagement/IndexStateManagementHistory.kt 80.00% <0.00%> (+1.37%) ⬆️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 70.17% <0.00%> (+1.46%) ⬆️
...management/indexstatemanagement/MetadataService.kt 64.92% <0.00%> (+2.23%) ⬆️
.../action/explain/TransportExplainTransformAction.kt 73.03% <0.00%> (+2.24%) ⬆️
...gement/indexstatemanagement/action/ShrinkAction.kt 70.58% <0.00%> (+2.94%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Angie-Zhang Angie-Zhang changed the title Change test page size to avoid indexTimeInMillis < 1 issue. Change test page size to avoid index/search TimeInMillis < 1 issue. Aug 10, 2022
khushbr
khushbr approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@khushbr khushbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this flaky test, Angie.

@bowenlan-amzn bowenlan-amzn merged commit 307ed55 into opensearch-project:main Aug 23, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2022
@Angie-Zhang @github-actions
Change test page size to avoid index/search TimeInMillis < 1 issue. (#…
acbbd3d 
…460)

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <[email protected]>

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <[email protected]>

Signed-off-by: Angie Zhang <[email protected]>
(cherry picked from commit 307ed55)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 23, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2022
@Angie-Zhang @github-actions
Change test page size to avoid index/search TimeInMillis < 1 issue. (#…
30b90fb 
…460)

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <[email protected]>

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <[email protected]>

Signed-off-by: Angie Zhang <[email protected]>
(cherry picked from commit 307ed55)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 23, 2022
Closed
@bowenlan-amzn bowenlan-amzn mentioned this pull request Aug 23, 2022
Closed
35 tasks
Angie-Zhang added a commit that referenced this pull request Aug 31, 2022
@opensearch-trigger-bot @Angie-Zhang
Change test page size to avoid index/search TimeInMillis < 1 issue. (#…
5ff8143 
…460) (#475)

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <[email protected]>

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <[email protected]>

Signed-off-by: Angie Zhang <[email protected]>
(cherry picked from commit 307ed55)

Co-authored-by: Angie Zhang <[email protected]>
Angie-Zhang added a commit to Angie-Zhang/index-management that referenced this pull request Sep 1, 2022
@Angie-Zhang
Change test page size to avoid index/search TimeInMillis < 1 issue. (o…
7742e4b 
…pensearch-project#460)

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <[email protected]>

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <[email protected]>

Signed-off-by: Angie Zhang <[email protected]>
(cherry picked from commit 307ed55)
Signed-off-by: Angie Zhang <[email protected]>
@Angie-Zhang Angie-Zhang deleted the intermit_failing_fix branch October 13, 2022 20:59
Angie-Zhang added a commit that referenced this pull request Oct 14, 2022
@jowg-amazon @petardz
@Angie-Zhang @stevanbz @xluo-aws @bowenlan-amzn @opensearch-trigger-bot @cwillum @deshsidd @lezzago @downsrob
Action Validation framework and Explain API integration (#441)
35b80e0 
* initial framework

Signed-off-by: Joanne Wang <[email protected]>

* Removed recursion from Explain Action to avoid stackoverflow in some situations (#419)

Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>

* enabled by default integrated

Signed-off-by: Joanne Wang <[email protected]>

* cleaned up comments and logs, created unit test and updated previous integration tests

Signed-off-by: Joanne Wang <[email protected]>

* added delete validation logic

Signed-off-by: Joanne Wang <[email protected]>

* fixed rollover validation unit tests

Signed-off-by: Joanne Wang <[email protected]>

* added validation info field to ManagedIndexMetaData

Signed-off-by: Joanne Wang <[email protected]>

* removed step context as input

Signed-off-by: Joanne Wang <[email protected]>

* added validationmetadata class

Signed-off-by: Joanne Wang <[email protected]>

* restored old integration tests and changed validation service output

Signed-off-by: Joanne Wang <[email protected]>

* before integrated validation meta data into managed index meta data

Signed-off-by: Joanne Wang <[email protected]>

* integrated validation meta data

Signed-off-by: Joanne Wang <[email protected]>

* working version

Signed-off-by: Joanne Wang <[email protected]>

* added validation mapping

Signed-off-by: Joanne Wang <[email protected]>

* fixed integ tests

Signed-off-by: Joanne Wang <[email protected]>

* renamed some values

Signed-off-by: Joanne Wang <[email protected]>

* before removing from managed index meta data

Signed-off-by: Joanne Wang <[email protected]>

* created validation result object in explain

Signed-off-by: Joanne Wang <[email protected]>

* testing

Signed-off-by: Joanne Wang <[email protected]>

* run fails

Signed-off-by: Joanne Wang <[email protected]>

* integration test for delete + added framework for force merge

Signed-off-by: Joanne Wang <[email protected]>

* removed step validation metadata and still testing explain results

Signed-off-by: Joanne Wang <[email protected]>

* before removing from managed index runner

Signed-off-by: Joanne Wang <[email protected]>

* removed from managed index runner

Signed-off-by: Joanne Wang <[email protected]>

* clean up and tests

Signed-off-by: Joanne Wang <[email protected]>

* all validation tests pass

Signed-off-by: Joanne Wang <[email protected]>

* removed validation result from all managed index meta data

Signed-off-by: Joanne Wang <[email protected]>

* restored old IT tests

Signed-off-by: Joanne Wang <[email protected]>

* fixed it tests, set explain validation to false

Signed-off-by: Joanne Wang <[email protected]>

* clean up

Signed-off-by: Joanne Wang <[email protected]>

* Change test page size to avoid index/search TimeInMillis < 1 issue. (#460)

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <[email protected]>

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <[email protected]>

Signed-off-by: Angie Zhang <[email protected]>

* Transform maxclauses fix (#477)

* transform maxClauses fix

Signed-off-by: Petar Dzepina <[email protected]>

* added bucket log to track processed buckets

Signed-off-by: Petar Dzepina <[email protected]>

* various renames/changes

Signed-off-by: Petar Dzepina <[email protected]>

* fixed detekt issues

Signed-off-by: Petar Dzepina <[email protected]>

* added comments to test

Signed-off-by: Petar Dzepina <[email protected]>

* removed debug logging

Signed-off-by: Petar Dzepina <[email protected]>

* empty commit to trigger checks

Signed-off-by: Petar Dzepina <[email protected]>

* reduced pageSize to 1 in few ITs to avoid flaky tests; fixed bug where pagesProcessed was calculated incorrectly

Signed-off-by: Petar Dzepina <[email protected]>

* reverted pagesProcessed change; fixed few ITs

Signed-off-by: Petar Dzepina <[email protected]>

Signed-off-by: Petar Dzepina <[email protected]>

* 483: Updated detekt plugin and snakeyaml dependency. Updated a code t… (#485)

* 483: Updated detekt plugin and snakeyaml dependency. Updated a code to reduce the number of issues after static analysis

Signed-off-by: Stevan Buzejic <[email protected]>

* 483: Updated snakeyaml version to use the latest

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>

* Remove HOST_DENY_LIST usage as Notification plugin will own it (#471)

(#107)

Signed-off-by: Xuesong Luo <[email protected]>

Signed-off-by: Xuesong Luo <[email protected]>

* Disable detekt because of the CVE (#497)

Signed-off-by: bowenlan-amzn <[email protected]>

Signed-off-by: bowenlan-amzn <[email protected]>

* Deprecate Master nonmenclature (#501)

Signed-off-by: bowenlan-amzn <[email protected]>

Signed-off-by: bowenlan-amzn <[email protected]>

* [AUTO] Increment version to 2.3.0-SNAPSHOT (#484) (#503)

* fix#921-README-forum-link-index_mgmnt (#499)

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>

* 64: Added rounding when using aggreagate script for avg metric. Added… (#490)

* 64: Added rounding when using aggreagate script for avg metric. Added unit tests for checking average aggregations against the target rollup index

Signed-off-by: Stevan Buzejic <[email protected]>

* 64: Rollup job renamed

Signed-off-by: Stevan Buzejic <[email protected]>

* 64: Removed unrelevant metrics for the avg calculation test

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>

* Revert Disable detekt and force choose snakeyml 1.32 (#528)

* Revert Disable detekt: 50ac1e9

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Remove force choosing snakeyml 1.31

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Force snakeyaml 1.32

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Empty commit

Signed-off-by: Siddhant Deshmukh <[email protected]>

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Added 2.3 release note (#507) (#515) (#517)

* Update 2.3 release note

Signed-off-by: Angie Zhang <[email protected]>

* Update 2.3 release note

Signed-off-by: Angie Zhang <[email protected]>

* Update 2.3 release note

Signed-off-by: Angie Zhang <[email protected]>

* Update 2.3 release note

Signed-off-by: Angie Zhang <[email protected]>

* Update 2.3 release note

Signed-off-by: Angie Zhang <[email protected]>

Signed-off-by: Angie Zhang <[email protected]>
(cherry picked from commit d9793ac)
Signed-off-by: Angie Zhang <[email protected]>

Signed-off-by: Angie Zhang <[email protected]>
(cherry picked from commit 7217b5b)

Co-authored-by: Angie Zhang <[email protected]>

* Add 2.2 release note (#450) (#452) (#516)

* Add 2.2 release note

Signed-off-by: Angie Zhang <[email protected]>

* Add 2.2 release note

Signed-off-by: Angie Zhang <[email protected]>

Co-authored-by: Angie Zhang <[email protected]>
(cherry picked from commit 8eb5da6)
Signed-off-by: Angie Zhang <[email protected]>

Signed-off-by: Angie Zhang <[email protected]>
Co-authored-by: Ashish Agrawal <[email protected]>

* Adds plugin version sweep background job (#434)

* [207]: Added 5 min scheduled job for sweeping ISM plugin version in the case of version discrepancy

Signed-off-by: Stevan Buzejic <[email protected]>

* [207]: Created pluginVersionSweepCoordinator component responsible for scheduling the skip execution task. Annotated tests in order to prevent thread leak error during integrational tests

Signed-off-by: Stevan Buzejic <[email protected]>

* [207]: Increased retry period for background job that sets the skip flag up to 5 mins

Signed-off-by: Stevan Buzejic <[email protected]>

* Empty-Commit

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>
Co-authored-by: Stevan Buzejic <[email protected]>

* flaky transform test fix attempt (#542)

* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <[email protected]>

* accidental paste fix

Signed-off-by: Petar Dzepina <[email protected]>

Signed-off-by: Petar Dzepina <[email protected]>
Co-authored-by: Petar Dzepina <[email protected]>

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Angie Zhang <[email protected]>
Signed-off-by: Stevan Buzejic <[email protected]>
Signed-off-by: Xuesong Luo <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: cwillum <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Co-authored-by: Petar <[email protected]>
Co-authored-by: Angie Zhang <[email protected]>
Co-authored-by: Stevan Buzejic <[email protected]>
Co-authored-by: xluo-aws <[email protected]>
Co-authored-by: bowenlan-amzn <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Chris Moore <[email protected]>
Co-authored-by: Siddhant Deshmukh <[email protected]>
Co-authored-by: Angie Zhang <[email protected]>
Co-authored-by: Ashish Agrawal <[email protected]>
Co-authored-by: Clay Downs <[email protected]>
Co-authored-by: Stevan Buzejic <[email protected]>
Co-authored-by: Petar Dzepina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushbr khushbr khushbr approved these changes

@bowenlan-amzn bowenlan-amzn bowenlan-amzn approved these changes

Assignees
No one assigned
Labels
backport 1.x backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Angie-Zhang @codecov-commenter @khushbr @bowenlan-amzn