Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incrementally remove resources from workflow state during deprovisioning #898

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Oct 3, 2024

Description

Removes resources from the workflow state list during deprovision incrementally. Retains the existing full-list update as a backup option.

Related Issues

Resolves #780
Resolves #691

Check List

  • New functionality includes testing.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (d0879d7) to head (55fd673).

Files with missing lines Patch % Lines
.../transport/DeprovisionWorkflowTransportAction.java 40.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #898      +/-   ##
============================================
+ Coverage     77.97%   78.01%   +0.03%     
- Complexity      977      982       +5     
============================================
  Files            97       97              
  Lines          4554     4575      +21     
  Branches        423      426       +3     
============================================
+ Hits           3551     3569      +18     
- Misses          827      829       +2     
- Partials        176      177       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
1 participant