Get installed plugins from local node and add a timeout #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
============================================
- Coverage 71.47% 71.41% -0.06%
Complexity 562 562
============================================
Files 73 73
Lines 3001 3016 +15
Branches 230 229 -1
============================================
+ Hits 2145 2154 +9
- Misses 746 752 +6
Partials 110 110 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Jan 3, 2024
src/main/java/org/opensearch/flowframework/workflow/WorkflowProcessSorter.java
Show resolved
Hide resolved
amitgalitz
approved these changes
Jan 3, 2024
owaiskazi19
reviewed
Jan 3, 2024
src/main/java/org/opensearch/flowframework/workflow/WorkflowProcessSorter.java
Show resolved
Hide resolved
It's being tested multinode in end-to-end testing which is how we found this issue to start with. But we could change |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit efdbcb0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jan 3, 2024
#357) Get installed plugins from local node and add a timeout (#353) (cherry picked from commit efdbcb0) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the installed plugin validation check to more closely match
_cat/plugins:Issues Resolved
Fixes #352
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.