Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/agent_framework] Add Undeploy Model Step #236

Merged

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Dec 1, 2023

Description

Adds a workflow step to undeploy a model.

Issues Resolved

Part of #89

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshpalis
Copy link
Member

Not related to this PR, but I've encountered this CI failure before and it seems like a flaky test, but I've never been able to reproduce it locally.

For encryption, we retrieve an instance of the JceMasterKey using the wrapping algorithm AES/GCM/NoPadding here, which this error indicates as the only correct wrapping algorithm to use.

Re-running the checks will always resolve this issue, but I'm unsure what the root cause of the failure is

REPRODUCE WITH: ./gradlew ':test' --tests "org.opensearch.flowframework.util.EncryptorUtilsTests.testEncryptDecryptTemplateCredential" -Dtests.seed=640FAD486BA2AFF -Dtests.security.manager=false -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=tr-TR -Dtests.timezone=Etc/UCT -Druntime.java=17
org.opensearch.flowframework.util.EncryptorUtilsTests > testEncryptDecryptTemplateCredential FAILED
    java.lang.IllegalArgumentException: Right now only AES/GCM/NoPadding is supported
        at __randomizedtesting.SeedInfo.seed([640FAD486BA2AFF:72B686C28E50824B]:0)
        at com.amazonaws.encryptionsdk.jce.JceMasterKey.getInstance(JceMasterKey.java:[66](https://github.com/opensearch-project/flow-framework/actions/runs/7065973095/job/19237007060?pr=236#step:7:67))
        at org.opensearch.flowframework.util.EncryptorUtils.encrypt(EncryptorUtils.java:185)
        at org.opensearch.flowframework.util.EncryptorUtils.lambda$processTemplateCredentials$0(EncryptorUtils.java:139)
        at java.base/java.util.HashMap.replaceAll(HashMap.java:1437)
        at org.opensearch.flowframework.util.EncryptorUtils.processTemplateCredentials(EncryptorUtils.java:139)
        at org.opensearch.flowframework.util.EncryptorUtils.encryptTemplateCredentials(EncryptorUtils.java:108)
        at org.opensearch.flowframework.util.EncryptorUtilsTests.testEncryptDecryptTemplateCredential(EncryptorUtilsTests.java:166)

@dbwiddis
Copy link
Member Author

dbwiddis commented Dec 2, 2023

it seems like a flaky test, but I've never been able to reproduce it locally.

Turns out an uppercase i in Turkish is not I. Known common locale issue.

Signed-off-by: Daniel Widdis <[email protected]>
@dbwiddis dbwiddis merged commit a216e5e into opensearch-project:feature/agent_framework Dec 2, 2023
10 checks passed
dbwiddis added a commit to dbwiddis/flow-framework that referenced this pull request Dec 15, 2023
dbwiddis added a commit to dbwiddis/flow-framework that referenced this pull request Dec 15, 2023
dbwiddis added a commit that referenced this pull request Dec 18, 2023
dbwiddis added a commit to dbwiddis/flow-framework that referenced this pull request Dec 18, 2023
dbwiddis added a commit that referenced this pull request Dec 18, 2023
@dbwiddis dbwiddis deleted the undeploy-model branch January 8, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants