Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates exception handling with FlowFrameworkException and fix Global Context mapping #106

Closed
wants to merge 8 commits into from

Using OpenSearch ExceptionsHelper to get rest status from failed clie…

d67a7c1
Select commit
Loading
Failed to load commit list.
Closed

Updates exception handling with FlowFrameworkException and fix Global Context mapping #106

Using OpenSearch ExceptionsHelper to get rest status from failed clie…
d67a7c1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 20, 2023 in 0s

79.04% (-2.42%) compared to 63ef780

View this Pull Request on Codecov

79.04% (-2.42%) compared to 63ef780

Details

Codecov Report

Merging #106 (d67a7c1) into main (63ef780) will decrease coverage by 2.42%.
The diff coverage is 40.78%.

@@             Coverage Diff              @@
##               main     #106      +/-   ##
============================================
- Coverage     81.46%   79.04%   -2.42%     
+ Complexity      285      263      -22     
============================================
  Files            30       30              
  Lines          1122     1026      -96     
  Branches        126      103      -23     
============================================
- Hits            914      811     -103     
- Misses          162      179      +17     
+ Partials         46       36      -10     
Files Coverage Δ
...lowframework/exception/FlowFrameworkException.java 45.45% <100.00%> (+5.45%) ⬆️
...ework/transport/CreateWorkflowTransportAction.java 100.00% <100.00%> (ø)
...opensearch/flowframework/workflow/ProcessNode.java 93.47% <100.00%> (ø)
...a/org/opensearch/flowframework/model/Template.java 89.54% <0.00%> (+2.26%) ⬆️
.../flowframework/workflow/WorkflowProcessSorter.java 97.10% <83.33%> (ø)
...ch/flowframework/indices/GlobalContextHandler.java 72.22% <50.00%> (ø)
...rk/transport/ProvisionWorkflowTransportAction.java 45.61% <42.85%> (ø)
...search/flowframework/workflow/CreateIndexStep.java 56.63% <8.33%> (-2.08%) ⬇️
...h/flowframework/rest/RestCreateWorkflowAction.java 45.83% <31.57%> (-20.84%) ⬇️
...lowframework/rest/RestProvisionWorkflowAction.java 48.00% <35.00%> (-24.73%) ⬇️

... and 1 file with indirect coverage changes