Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-date histogram aggregations documentation #7630

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

vagimeli
Copy link
Collaborator

@vagimeli vagimeli commented Jul 3, 2024

Description

Closes content gaps for the following bucket aggregations:
Auto-interval date histogram
Children
Composite
Parent
Rare terms

Issues Resolved

#4293

Version

Backport to latest version

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli vagimeli self-assigned this Jul 3, 2024
@vagimeli vagimeli added Needs SME Waiting on input from subject matter expert Content gap 2 - In progress Issue/PR: The issue or PR is in progress. labels Jul 3, 2024
Signed-off-by: Melissa Vagi <[email protected]>

Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli changed the title Add bucket aggregations documentation Add auto-date histogram aggregations documentation Jul 8, 2024
@vagimeli vagimeli linked an issue Aug 23, 2024 that may be closed by this pull request
4 tasks
@vagimeli vagimeli added 4 - Doc review PR: Doc review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. Needs SME Waiting on input from subject matter expert labels Aug 30, 2024
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vagimeli! Can we add more info about these parameters? Is there granularity to the returned intervals? What are the formats for dates/times and time zones? Is there a default time zone?

@bowenlan-amzn Please provide technical input about the above questions. Where can I find these details?

_aggregations/bucket/auto-interval-date-histogram.md Outdated Show resolved Hide resolved
_aggregations/bucket/auto-interval-date-histogram.md Outdated Show resolved Hide resolved
```
{% include copy-curl.html %}

#### Example response
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this heading, I would use a sentence describing what the response contains.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowenlan-amzn Please help me address the information gap. Can you explain the response from a novice user point of view?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can provide the data you have indexed, this can just be the response of the previous search request

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowenlan-amzn Please verify the revised text is technically accurate. Thank you.

"auto_date_histogram": {
"field": "timestamp",
"buckets": 2,
"minimum_interval": "day",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this parameter specify?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowenlan-amzn Please help me address the information gap. See comment above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The accepted units for minimum_interval are:

year
month
day
hour
minute
second

auto date histogram won't try the interval shorter than the one specified.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowenlan-amzn Please confirm the revised text is technically accurate. Thank you.

"field": "timestamp",
"buckets": 2,
"minimum_interval": "day",
"time_zone": "America/Los_Angeles",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the possible formats for time_zone?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowenlan-amzn Please help me address the information gap. See comment above.

"buckets": 2,
"minimum_interval": "day",
"time_zone": "America/Los_Angeles",
"format": "yyyy-MM-dd HH:mm:ss"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the possible formats for dates?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowenlan-amzn Please help me address the information gap. See comment above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any time data (date field), format and timezone are consistent. I would expect we have a different documentation page about these

@vagimeli
Copy link
Collaborator Author

vagimeli commented Oct 2, 2024

Thank you, @vagimeli! Can we add more info about these parameters? Is there granularity to the returned intervals? What are the formats for dates/times and time zones? Is there a default time zone?

@bowenlan-amzn Please provide technical input about the above questions. Where can I find these details?

Hi @bowenlan-amzn @kolchfa-aws I've addressed feedback comments. Please review and approve at your availability. Thank you :)

@vagimeli vagimeli added 2 - In progress Issue/PR: The issue or PR is in progress. and removed 4 - Doc review PR: Doc review in progress labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In progress Issue/PR: The issue or PR is in progress. aggregations and analyzers Content gap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Restructure aggregations pages into subpages
3 participants