Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
andrross,
reta,
nknize and
sarthakaggarwal97
as code owners
22 tasks
reta
approved these changes
Jul 9, 2024
|
The GA checks should be fixed by #163 |
|
Can we merge this pls? I'm not a maintainer here. |
@dblock could you rebase please? so we could get green checks, thank you |
…cklist. Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
update-pull-request-template
branch
from
d61ae8a
to
0478a76
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
…cklist. (#162) Signed-off-by: dblock <[email protected]> (cherry picked from commit 9a7b217) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Aug 1, 2024
…cklist. (#162) (#178) (cherry picked from commit 9a7b217) Signed-off-by: dblock <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from opensearch-project/opensearch-api-specification#387, update PR template to include a checkbox that requests that all API changes be documented in the OpenAPI spec used to generate clients.