-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging for version increment automation. #192
Conversation
Signed-off-by: pgodithi <[email protected]>
Signed-off-by: pgodithi <[email protected]>
Signed-off-by: opensearch-ci-bot <[email protected]>
…NAPSHOT [AUTO] Version Increment to 1.3.4-SNAPSHOT
Signed-off-by: pgodithi <[email protected]>
Signed-off-by: pgodithi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the change of System.getProperty
for project.property
really necessary as part of this?
Hey @dblock This change is necessary (the main change that drives the version increment automation), the idea from the solution is to make sure we maintain a More detailsA gradle project property (-P)is a property that can be accessed in project’s System properties(-D) are accessed via normal Java/Groovy system properties access methods (works only for runtime injection). |
Hey @dblock I understand your concern, since this |
Ok, I think I understand. The real reason is that If you do it before it might be easier/smaller amount of changes, especially if you need to modify files that aren't just
|
Yes @dblock without having property change we can still proceed to version increment, We solely rely on |
Also @dblock adding to your point to use |
Signed-off-by: pgodithi <[email protected]>
Signed-off-by: pgodithi <[email protected]>
Hey @dblock Pushed the change in my latest commit, can you please check the task now considering the above inputs.
opensearch_version property (here from above line the default is |
Signed-off-by: pgodithi <[email protected]>
Signed-off-by: pgodithi <[email protected]>
Thanks @dblock for all the details, I see now why onlyIF is good use case here. I have pushed the change in my latest commit.
|
Signed-off-by: pgodithi <[email protected]>
Signed-off-by: pgodithi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
I imagine you're renaming tasks following opensearch-project/opensearch-plugin-template-java#32? |
Ye @dblock I will be shortly pushing the code renaming the task as |
Signed-off-by: pgodithi <[email protected]>
89ba85a
Yep, use backports. |
Description
This is the staging PR for to execute workflows that auto raise the version increment PR's
Example: prudhvigodithi#1
Issues Resolved
Part of: opensearch-project/opensearch-build#1375
From solution: opensearch-project/opensearch-build#1375 (comment)
Related issue: #193
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.