Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cklist. Signed-off-by: dblock <[email protected]>
dblock
requested review from
jmazanec15,
jngz-es,
kaituo,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
opensearch-trigger-bot
bot
added
infra
22 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
============================================
+ Coverage 71.83% 77.08% +5.25%
- Complexity 4898 5290 +392
============================================
Files 518 517 -1
Lines 22879 22890 +11
Branches 2245 2239 -6
============================================
+ Hits 16434 17645 +1211
+ Misses 5410 4212 -1198
+ Partials 1035 1033 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
owaiskazi19
approved these changes
Jul 9, 2024
vamshin
reviewed
Jul 9, 2024
| ### Check List | ||
| - [ ] New functionality includes testing. | ||
| - [ ] New functionality has been documented. | ||
| - [ ] API changes companion pull request [created](https://github.com/opensearch-project/opensearch-api-specification/blob/main/DEVELOPER_GUIDE.md). |
There was a problem hiding this comment.
To me its not coming out clear from messaging side. Should we say something like
- New/Modify Existing APIs. API changes companion pull request created.
There was a problem hiding this comment.
I propose to keep it consistent with other repos (x20 PRs), this is the language that was chosen in core.
|
@owaiskazi19 can we merge? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
…cklist. (#1262) Signed-off-by: dblock <[email protected]> (cherry picked from commit 5ec5bd1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jackiehanyang
pushed a commit
that referenced
this pull request
Jul 25, 2024
…cklist. (#1262) (#1266) (cherry picked from commit 5ec5bd1) Signed-off-by: dblock <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from opensearch-project/opensearch-api-specification#387, update PR template to include a checkbox that requests that all API changes be documented in the OpenAPI spec used to generate clients.