Fix Duplicate Scheduling of Index Rollover in ADIndexManagement #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADIndexManagement inherits from IndexManagement, which implements LocalNodeClusterManagerListener, causing it to listen for master node changes. This listener schedules index rollover and deletion. However, ADIndexManagement was inadvertently listening to the cluster manager event again, leading to duplicate scheduling of these tasks. This commit removes the redundant listener call in ADIndexManagement, ensuring that index rollover and deletion are scheduled only once per interval. Testing: Verified that index rollover and deletion now execute once per interval as expected. Signed-off-by: Kaituo Li <[email protected]>
kaituo
requested review from
jmazanec15,
jngz-es,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
jackiehanyang
approved these changes
Jun 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
ADIndexManagement inherits from IndexManagement, which implements LocalNodeClusterManagerListener, causing it to listen for master node changes. This listener schedules index rollover and deletion. However, ADIndexManagement was inadvertently listening to the cluster manager event again, leading to duplicate scheduling of these tasks. This commit removes the redundant listener call in ADIndexManagement, ensuring that index rollover and deletion are scheduled only once per interval. Testing: Verified that index rollover and deletion now execute once per interval as expected. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 744a24f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaituo
pushed a commit
that referenced
this pull request
Jun 10, 2024
… (#1233) ADIndexManagement inherits from IndexManagement, which implements LocalNodeClusterManagerListener, causing it to listen for master node changes. This listener schedules index rollover and deletion. However, ADIndexManagement was inadvertently listening to the cluster manager event again, leading to duplicate scheduling of these tasks. This commit removes the redundant listener call in ADIndexManagement, ensuring that index rollover and deletion are scheduled only once per interval. Testing: Verified that index rollover and deletion now execute once per interval as expected. (cherry picked from commit 744a24f) Signed-off-by: Kaituo Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADIndexManagement inherits from IndexManagement, which implements LocalNodeClusterManagerListener, causing it to listen for master node changes. This listener schedules index rollover and deletion. However, ADIndexManagement was inadvertently listening to the cluster manager event again, leading to duplicate scheduling of these tasks.
This commit removes the redundant listener call in ADIndexManagement, ensuring that index rollover and deletion are scheduled only once per interval.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.