change request type to ActionRequest BaseGetConfigTransportAction to … #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix class cast exception Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
jmazanec15,
jngz-es,
kaituo,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
5 tasks
kaituo
approved these changes
Jun 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…fix class cast exception (#1221) Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 9eed2ff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaituo
pushed a commit
that referenced
this pull request
Jun 5, 2024
…fix class cast exception (#1221) (#1222) (cherry picked from commit 9eed2ff) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fix class cast exception
Description
ActionRequestis the basic class and defined in core, so the class loader for this class will be OpenSearch core instead of Ad plugin. If we change toGetConfigRequestthat defined in AD plugin, the class loader for this class will Ad plugin class loader in Ad plugin, and skills plugin class loader in Skill plugin, that will cause class cast exception.please note, skill plugin don't depends on Ad plugin, so they don't have parent and child relationship.
recencyEmphasis,seasonIntervals,historyIntervalsareIntegertype, basically they could be null, change to read/write Optional.try to add a unit test for
AnomalyDetectorserialization and deserializationIssues Resolved
#1220
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.