[BucketLevelMonitor] Multi-term agg support #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petardz
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
Codecov Report
@@ Coverage Diff @@
## main #964 +/- ##
============================================
- Coverage 75.05% 74.79% -0.26%
Complexity 111 111
============================================
Files 144 144
Lines 8341 8343 +2
Branches 1213 1215 +2
============================================
- Hits 6260 6240 -20
- Misses 1465 1485 +20
- Partials 616 618 +2
|
petardz
force-pushed
the
mutli-term-agg-fix
branch
from
6f830a1
to
eda83f5
Compare
lezzago
reviewed
Jun 28, 2023
| val searchResult = (output.objectMap("input_results")["results"] as List<Map<String, Any>>).first() | ||
| @Suppress("UNCHECKED_CAST") | ||
| val buckets = searchResult.stringMap("aggregations")?.stringMap("hot")?.get("buckets") as List<Map<String, Any>> | ||
| assertEquals("Incorrect search result", 2, buckets.size) |
There was a problem hiding this comment.
Should we check the result to ensure its getting the right values?
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>
petardz
force-pushed
the
mutli-term-agg-fix
branch
from
42cc139
to
79a1a82
Compare
lezzago
approved these changes
Jun 28, 2023
getsaurabh02
approved these changes
Jul 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
* added handling of multi-term agg in bucketlevel monitors Signed-off-by: Petar Dzepina <[email protected]> * added handling of multi-term agg in bucketlevel monitors Signed-off-by: Petar Dzepina <[email protected]> * added more asserts Signed-off-by: Petar Dzepina <[email protected]> --------- Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit a3db266)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
* added handling of multi-term agg in bucketlevel monitors Signed-off-by: Petar Dzepina <[email protected]> * added handling of multi-term agg in bucketlevel monitors Signed-off-by: Petar Dzepina <[email protected]> * added more asserts Signed-off-by: Petar Dzepina <[email protected]> --------- Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit a3db266)
AWSHurneyt
pushed a commit
that referenced
this pull request
Jul 11, 2023
* added handling of multi-term agg in bucketlevel monitors Signed-off-by: Petar Dzepina <[email protected]> * added handling of multi-term agg in bucketlevel monitors Signed-off-by: Petar Dzepina <[email protected]> * added more asserts Signed-off-by: Petar Dzepina <[email protected]> --------- Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit a3db266) Co-authored-by: Petar Dzepina <[email protected]>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jul 11, 2023
* added handling of multi-term agg in bucketlevel monitors Signed-off-by: Petar Dzepina <[email protected]> * added handling of multi-term agg in bucketlevel monitors Signed-off-by: Petar Dzepina <[email protected]> * added more asserts Signed-off-by: Petar Dzepina <[email protected]> --------- Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit a3db266) Co-authored-by: Petar Dzepina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #, if available: #798
Description of changes:
CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.