add workflow type field exists check in search monitors action to return both workflows and monitors on search #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unr both workflows and monitors on search Signed-off-by: Surya Sashank Nistala <[email protected]>
… for search Associated monitors Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
lezzago
approved these changes
Jul 13, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1026 +/- ##
============================================
+ Coverage 72.56% 72.65% +0.09%
Complexity 119 119
============================================
Files 160 160
Lines 10434 10447 +13
Branches 1571 1572 +1
============================================
+ Hits 7571 7590 +19
+ Misses 1968 1962 -6
Partials 895 895
|
AWSHurneyt
approved these changes
Jul 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
…urn both workflows and monitors on search (#1026) * add workflow type field exists check in search monitors action to retunr both workflows and monitors on search Signed-off-by: Surya Sashank Nistala <[email protected]> * remove .get() invocation on future and replace with suspendUntil call for search Associated monitors Signed-off-by: Surya Sashank Nistala <[email protected]> * add workflowIds param in rest get alerts action Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 064e5f5)
eirsep
added a commit
that referenced
this pull request
Jul 14, 2023
…urn both workflows and monitors on search (#1026) (#1027) * add workflow type field exists check in search monitors action to retunr both workflows and monitors on search Signed-off-by: Surya Sashank Nistala <[email protected]> * remove .get() invocation on future and replace with suspendUntil call for search Associated monitors Signed-off-by: Surya Sashank Nistala <[email protected]> * add workflowIds param in rest get alerts action Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 064e5f5) Co-authored-by: Surya Sashank Nistala <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…urn both workflows and monitors on search (#1026) * add workflow type field exists check in search monitors action to retunr both workflows and monitors on search Signed-off-by: Surya Sashank Nistala <[email protected]> * remove .get() invocation on future and replace with suspendUntil call for search Associated monitors Signed-off-by: Surya Sashank Nistala <[email protected]> * add workflowIds param in rest get alerts action Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 064e5f5)
lezzago
pushed a commit
that referenced
this pull request
Jul 26, 2023
…urn both workflows and monitors on search (#1026) (#1053) * add workflow type field exists check in search monitors action to retunr both workflows and monitors on search Signed-off-by: Surya Sashank Nistala <[email protected]> * remove .get() invocation on future and replace with suspendUntil call for search Associated monitors Signed-off-by: Surya Sashank Nistala <[email protected]> * add workflowIds param in rest get alerts action Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 064e5f5) Co-authored-by: Surya Sashank Nistala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add workflow type field exists check in search monitors action to return both workflows and monitors on search
Added test to verify Search Monitors API would return both workflows and monitors
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.