Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.9] Fix get alerts api to also return chained alerts with default params. and skip audit state alerts #1023

Merged
merged 1 commit into from
Jul 13, 2023
Merged

[Backport 2.9] Fix get alerts api to also return chained alerts with default params. and skip audit state alerts #1023

merged 1 commit into from
Jul 13, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0add91f from #1020

@eirsep @github-actions
Fix get alerts api to also return chained alerts with default params.…
c39ee31 
… and skip audit state alerts (#1020)

* fix get alerts api with default params to return chained alerts and skip audit alerts

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix alert state query filter for get workflow alerts to avoid audit alerts and fetch only chained alerts

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix typo

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 0add91f)
@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #1023 (c39ee31) into 2.9 (0c698e5) will increase coverage by 0.19%.
The diff coverage is 95.45%.

@@             Coverage Diff              @@
##                2.9    #1023      +/-   ##
============================================
+ Coverage     72.50%   72.70%   +0.19%     
  Complexity      119      119              
============================================
  Files           160      160              
  Lines         10431    10441      +10     
  Branches       1570     1572       +2     
============================================
+ Hits           7563     7591      +28     
+ Misses         1979     1955      -24     
- Partials        889      895       +6
Impacted Files Coverage Δ
...rch/alerting/transport/TransportGetAlertsAction.kt 75.60% <92.85%> (+0.82%) ⬆️
.../org/opensearch/alerting/MonitorMetadataService.kt 64.92% <100.00%> (ø)
...ting/transport/TransportGetWorkflowAlertsAction.kt 66.66% <100.00%> (+0.59%) ⬆️
...earch/alerting/workflow/CompositeWorkflowRunner.kt 70.76% <100.00%> (+0.51%) ⬆️

... and 10 files with indirect coverage changes

@eirsep eirsep merged commit c2ab466 into 2.9 Jul 13, 2023
11 of 16 checks passed
@github-actions github-actions bot deleted the backport/backport-1020-to-2.9 branch July 13, 2023 02:35
@prudhvigodithi prudhvigodithi mentioned this pull request Jul 13, 2023
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirsep eirsep eirsep approved these changes

@lezzago lezzago lezzago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eirsep @lezzago